Skip to content

Conversation

@maxrussell
Copy link
Contributor

Test Plan

Release notes and error log in harness should link to my gist rather than Ryan's.

@maxrussell maxrussell requested a review from a team as a code owner November 20, 2024 20:36
@cla-bot cla-bot bot added the cla-signed label Nov 20, 2024
@determined-ci determined-ci requested a review from a team November 20, 2024 20:36
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 20, 2024
@netlify
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 5fd9d7a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673e483b0f299b0008dfea1c

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.67%. Comparing base (d189416) to head (5fd9d7a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10221      +/-   ##
==========================================
- Coverage   57.63%   53.67%   -3.97%     
==========================================
  Files         751     1255     +504     
  Lines      103234   155688   +52454     
  Branches     3617     3618       +1     
==========================================
+ Hits        59503    83561   +24058     
- Misses      43598    71994   +28396     
  Partials      133      133              
Flag Coverage Δ
backend 45.79% <ø> (+1.99%) ⬆️
harness 67.37% <ø> (ø)
web 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
harness/determined/deploy/aws/aws.py 10.75% <ø> (ø)

... and 504 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@mackrorysd mackrorysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@maxrussell maxrussell merged commit 5bf98b2 into main Nov 20, 2024
25 of 27 checks passed
@maxrussell maxrussell deleted the max/update-migration-gist branch November 20, 2024 20:57
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-0.38.0 cla-signed documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants