ci: fix oss and ee release process and add ee-dryrun release process #10249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP Fix ee release and ee dryrun release processes
Add release-ee-dryrun
…in goreleaser files
✅ Deploy Preview for determined-ui canceled.
|
maxrussell
approved these changes
Mar 7, 2025
Contributor
maxrussell
left a comment
maxrussell
left a comment
There was a problem hiding this comment.
Just that nit about the comment. LGTM either way.
agent/.goreleaser_ee_dryrun.yml
Outdated
Comment on lines
27
to
60
| #brews: | ||
| # - name: determined-agent | ||
| # tap: | ||
| # owner: determined-ai | ||
| # name: homebrew-determined | ||
| # url_template: "https://github.com/determined-ai/determined/releases/download/{{ .Tag }}/{{ .ArtifactName }}" | ||
| # caveats: | | ||
| # Determined agent config is located at #{etc}/determined/agent.yaml | ||
| # homepage: "https://github.com/determined-ai/determined" | ||
| # license: "Apache-2.0" | ||
| # folder: Formula | ||
| # install: | | ||
| # bin.install "determined-agent" | ||
| # | ||
| # doc.install "LICENSE" | ||
| # | ||
| # (var/"log/determined").mkpath | ||
| # | ||
| # (etc/"determined").mkpath | ||
| # inreplace "etc/determined/agent.yaml" do |s| | ||
| # s.gsub! "# master_host: 0.0.0.0", "master_host: 127.0.0.1" | ||
| # s.gsub! "# master_port: 80", "master_port: 8080" | ||
| # end | ||
| # | ||
| # Pathname("etc/determined/agent.yaml").append_lines <<~EOS | ||
| # container_master_host: host.docker.internal | ||
| # EOS | ||
| # | ||
| # etc.install "etc/determined/agent.yaml" => "determined/agent.yaml" | ||
| # service: | | ||
| # run [opt_bin/"determined-agent", "--config-file", etc/"determined/agent.yaml"] | ||
| # keep_alive false | ||
| # error_log_path var/"log/determined/agent-stderr.log" | ||
| # log_path var/"log/determined/agent-stdout.log" |
Contributor
There was a problem hiding this comment.
Nit: maybe we should just cut this comment, since we're extremely unlikely to ever uncomment this.
| name_template: "hpe-mlde-helm-chart_{{ .VERSION }}.tgz" | ||
|
|
||
| # be sure to keep this in sync between agent/master/helm | ||
| # the "include" functionality is only in the pro version |
Contributor
There was a problem hiding this comment.
the "include" functionality is only in the pro version
Contributor
Author
There was a problem hiding this comment.
Ah, "include" helps reduce duplication https://goreleaser.com/customization/includes/
Contributor
There was a problem hiding this comment.
Yeah, I'm just doing that glare at them about making that feature only available in the pro version.
jgongd
added a commit
that referenced
this pull request
Mar 12, 2025
…10249) * add an ee-dryrun release process * Correct the usage of .Env.VERSION_DOCKER, .ENV.VERSION and .VERSION in the goreleaser yml files. * fix a qemu error in docker build arm images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ee-dryrunrelease processTest Plan
CircleCI workflows
release,release-dryrun,release-ee, andrelease-ee-dryrunare green.Checklist
docs/release-notes/See Release Note for details.