chore: upgrade swagger-ui to v5.20.0 #10250
Merged
+41
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to fix a vulnerability in the Try-it-out feature. GHSA-qrmm-w75w-3wpx
✅ Deploy Preview for determined-ui canceled.
|
hkang1
reviewed
Mar 10, 2025
Contributor
hkang1
left a comment
hkang1
left a comment
There was a problem hiding this comment.
Just one question about the replace() function, the rest look good
|
|
||
| if (/code|token|error/.test(window.location.hash)) { | ||
| qp = window.location.hash.substring(1); | ||
| qp = window.location.hash.substring(1).replace('?', '&'); |
Contributor
There was a problem hiding this comment.
question: what is the replace for? do question marks get entered into the hash somehow?
Contributor
Author
There was a problem hiding this comment.
It appears to fix a parsing error when someone uses casdoor: swagger-api/swagger-ui#8149
hkang1
approved these changes
Mar 11, 2025
Contributor
hkang1
left a comment
hkang1
left a comment
There was a problem hiding this comment.
LGTM, thanks for the upgrade and fix
jgongd
added a commit
that referenced
this pull request
Mar 12, 2025
Upgrade to fix a vulnerability in the Try-it-out feature: GHSA-qrmm-w75w-3wpx We've chosen the SwaggerUI standalone installation that doesn't require npm: https://github.com/swagger-api/swagger-ui/blob/80d56c9518af7ad523f7171815c9da836551e259/docs/usage/installation.md#plain-old-htmlcssjs-standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to fix a vulnerability in the Try-it-out feature.
GHSA-qrmm-w75w-3wpx
We've chosen the SwaggerUI standalone installation that doesn't require npm: https://github.com/swagger-api/swagger-ui/blob/80d56c9518af7ad523f7171815c9da836551e259/docs/usage/installation.md#plain-old-htmlcssjs-standalone
Test Plan
make -C proto buildgenerates the latestapi.swagger.jsonmake -C docs buildmake -C docs liveA determined rest api page is expected:
Checklist
docs/release-notes/See Release Note for details.