Skip to content

Conversation

@jgongd
Copy link
Contributor

@jgongd jgongd commented Mar 19, 2025

Description

aiohttp-cors 0.8.0 breaks ray 2.10.0 (the latest version python 3.8 supports)

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jgongd jgongd requested a review from a team as a code owner March 19, 2025 20:48
@jgongd jgongd requested a review from azhou-determined March 19, 2025 20:48
@cla-bot cla-bot bot added the cla-signed label Mar 19, 2025
@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 58f8dc9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67db33ba2e4e96000864dd5d

@jgongd jgongd force-pushed the jgong/pin-aiohttp branch from 1b8743e to 23fab1e Compare March 19, 2025 21:11
@jgongd jgongd changed the title chore: pin aiohttp chore: pin aiohttp-cors Mar 19, 2025
@jgongd jgongd force-pushed the jgong/pin-aiohttp branch from 23fab1e to 58f8dc9 Compare March 19, 2025 21:14
Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@jgongd jgongd merged commit 9402563 into main Mar 19, 2025
77 of 90 checks passed
@jgongd jgongd deleted the jgong/pin-aiohttp branch March 19, 2025 21:51
jgongd added a commit that referenced this pull request Mar 19, 2025
aiohttp-cors 0.8.0 breaks ray 2.10.0 (the latest version python 3.8 supports)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants