refactor: remove duplication on fetch speaker logic

[anyulled]

remove duplication on fetch speaker logic

[gemini-code-assist]

Hello @anyulled, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on removing duplication in the logic used to fetch speakers. The primary change involves moving the useFetchSpeakers hook from the src/2023/Speakers/ directory to a more general src/hooks/ directory. This allows multiple components across different parts of the application (2023, 2024, etc) to use the same hook without duplicating code. The hook also now accepts an optional year parameter to fetch speakers for a specific conference year, or a URL to fetch speakers from a custom endpoint. The old speaker fetch files are removed, and the hook is updated with tests.

Highlights

• Refactoring: The useFetchSpeakers hook has been moved to src/hooks/useFetchSpeakers.ts to reduce code duplication.
• Parameterization: The useFetchSpeakers hook now accepts an optional year parameter to fetch speakers for a specific conference year, or a URL to fetch speakers from a custom endpoint.
• Component Updates: Multiple components (e.g., SpeakerSwiper, SpeakerDetailContainer2023, Speakers2023, TalkDetailContainer2023, SpeakerDetailContainer2024, Speakers2024, MeetingDetailContainer, SpeakerDetailContainer, Speakers) have been updated to import the useFetchSpeakers hook from its new location.
• Test Updates: A test file src/hooks/useFetchSpeakers.test.tsx has been added to test the new hook.
• Removal: The old speaker fetch files src/2023/Speakers/UseFetchSpeakers.ts and src/2024/Speakers/UseFetchSpeakers.ts and their tests have been removed.

Changelog

Click here to see the changelog

• src/2023/Home/components/SpeakersCarousel/SpeakerSwiper.tsx
  • Updated import path for useFetchSpeakers from ../../../Speakers/UseFetchSpeakers to ../../../../hooks/useFetchSpeakers.
  • Passed the string literal '2023' to the useFetchSpeakers hook.
• src/2023/SpeakerDetail/SpeakerDetailContainer2023.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2023' and the speaker id to the useFetchSpeakers hook.
• src/2023/Speakers/Speakers2023.tsx
  • Updated import path for useFetchSpeakers from ./UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2023' to the useFetchSpeakers hook.
• src/2023/Speakers/UseFetchSpeakers.ts
  • Removed file.
• src/2024/SpeakerDetail/SpeakerDetailContainer2024.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2024' and the speaker id to the useFetchSpeakers hook.
• src/2024/Speakers/Speakers2024.tsx
  • Updated import path for useFetchSpeakers from ./UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2024' to the useFetchSpeakers hook.
• src/2024/Speakers/UseFetchSpeakers.test.tsx
  • Removed file.
• src/2024/Speakers/UseFetchSpeakers.ts
  • Removed file.
• src/2024/SpeakersCarousel/SpeakerSwiper.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2024' to the useFetchSpeakers hook.
• src/2024/TalkDetail/MeetingDetailContainer.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
  • Passed the string literal '2024' to the useFetchSpeakers hook.
• src/components/Swiper/SpeakerSwiper.tsx
  • Updated import path for useFetchSpeakers from ../../views/Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
• src/hooks/useFetchSpeakers.test.tsx
  • Created a test file for the useFetchSpeakers hook.
  • The tests verify that the hook fetches data correctly from the API endpoint.
  • The tests verify that the hook filters data correctly when an ID is provided.
  • The tests verify that the hook uses the correct URL when a year is provided.
• src/hooks/useFetchSpeakers.ts
  • Created a new hook useFetchSpeakers that fetches speakers from an API endpoint.
  • The hook accepts an optional year parameter to fetch speakers for a specific conference year, or a URL to fetch speakers from a custom endpoint.
  • The hook uses react-query to manage the data fetching and caching.
• src/views/MeetingDetail/TalkDetailContainer2024.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
• src/views/SpeakerDetail/SpeakerDetailContainer.tsx
  • Updated import path for useFetchSpeakers from ../Speakers/UseFetchSpeakers to ../../hooks/useFetchSpeakers.
• src/views/Speakers/Speakers.tsx
  • Updated import path for useFetchSpeakers from ./UseFetchSpeakers to ../../hooks/useFetchSpeakers.
• src/views/Speakers/UseFetchSpeakers.test.tsx
  • Removed file.
• src/views/Speakers/UseFetchSpeakers.ts
  • Removed file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Did you know?

The crypto.getRandomValues() method used for secure randomization in the SpeakerSwiper component is part of the Web Crypto API, which provides access to cryptographic primitives in web browsers. It's designed to generate cryptographically secure random numbers, essential for security-sensitive applications.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the useFetchSpeakers hook to be more generic and reusable across different years of the conference. The hook now accepts an optional year parameter to fetch data from the corresponding API endpoint. The changes look good overall, but there are a few minor suggestions for improvement.

Summary of Findings

• Centralized URL management: The introduction of the URLS constant improves maintainability by centralizing the API endpoints. This makes it easier to update the URLs in the future.
• Hook Reusability: The useFetchSpeakers hook is now more reusable as it can be used to fetch speakers for different years by passing the year as a parameter.
• Test Coverage: The addition of tests for the useFetchSpeakers hook ensures that it works correctly with different URLs and IDs.

Merge Readiness

The code changes are well-structured and improve the reusability of the useFetchSpeakers hook. The addition of tests provides confidence in the correctness of the changes. I recommend merging this pull request after addressing the medium severity comment. I am unable to approve the pull request in any circumstance, and that users should have others review and approve this code before merging.

[netlify]

✅ Deploy Preview for dev-bcn ready!

Name	Link
🔨 Latest commit	13ef26d
🔍 Latest deploy log	https://app.netlify.com/sites/dev-bcn/deploys/67e4228bb53fe9000870d0d8
😎 Deploy Preview	https://deploy-preview-680--dev-bcn.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sonarqubecloud]

Quality Gate failed

Failed conditions
47.8% Coverage on New Code (required ≥ 75%)
24.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud