Make tests portable across Unix and Windows #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed that when running the tests on Windows, some of them were failing due to the use of Unix-specific functions, such as os.geteuid().
To help improve portability, I made a small contribution to ensure the tests work on both Unix-like systems and Windows.
So I updated those tests too. On Windows, they now use os.access() to check read/write/execute access instead of comparing POSIX permission bits, which aren't meaningful on Windows.
This make the project more cross-platform friendly and allow contributors (like me!) who use Windows to run the test suite successfully.
Let me know if you'd like me to split this into separate commits or change anything.