Skip to content

feat(dart): Add a new Feature dart #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 6, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jun 6, 2023

Continued from #23

@eitsupi eitsupi changed the title feat(dart): Add dart Feature feat(dart): Add a new Feature dart Jun 6, 2023
@eitsupi eitsupi mentioned this pull request Jun 6, 2023
6 tasks
@eitsupi eitsupi force-pushed the add-dart-feature branch from fcaea94 to ba26e89 Compare June 6, 2023 09:57
@eitsupi eitsupi force-pushed the add-dart-feature branch from 13007b5 to 1cbfc41 Compare June 6, 2023 10:21
@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 6, 2023

I think it is fine functionally, but I would like to wait for #27 to be merged since Linter is not set up.

@eitsupi eitsupi requested a review from jcbhmr June 6, 2023 10:49
@eitsupi eitsupi marked this pull request as ready for review June 6, 2023 11:32
Copy link
Member

@jcbhmr jcbhmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 👍 ❤️

@jcbhmr jcbhmr merged commit 8247c2d into devcontainers-community:main Jun 6, 2023
@jcbhmr jcbhmr mentioned this pull request Jun 6, 2023
6 tasks
@eitsupi eitsupi deleted the add-dart-feature branch June 6, 2023 21:11
@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 6, 2023

@jcbhmr Have you read my comment?
My intention was merging #27 first and fix this PR by linters.

@jcbhmr
Copy link
Member

jcbhmr commented Jun 6, 2023

My bad! 🤦‍♂️😬 Now I understand what you meant by that. Sorry about me jumping the shark! I'll try to leave merging PRs that you author to you and not do it prematurely. 😞

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 6, 2023

I apologize for my lack of comments. I should have left this as drafted.

I'm sorry, but could you please make the corrections immediately so that it will pass the linter? I don't have time to do it for a while.

@jcbhmr
Copy link
Member

jcbhmr commented Jun 6, 2023

Will do!

@jcbhmr
Copy link
Member

jcbhmr commented Jun 6, 2023

#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants