Skip to content

Introducing the interface for features publish command #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Aug 17, 2022
Merged

Introducing the interface for features publish command #97

merged 35 commits into from
Aug 17, 2022

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale commented Aug 2, 2022 •
edited
Loading

Builds on #94 and #99

Introducing the interface for features publish command.

  • Packs the features
  • Computes semantic versions for the features
  • Consumes changes in OCI push #99
  • Added tests

image

@samruddhikhandale samruddhikhandale changed the base branch from main to jospicer/package-features August 2, 2022 16:01
Base automatically changed from jospicer/package-features to main August 8, 2022 15:34
@joshspicer joshspicer mentioned this pull request Aug 11, 2022
Merged
@samruddhikhandale
Copy link
Member Author

As we've seen in the GH action we will likely get rate-limited now and again by container registries. We could either put the retry logic here or in the lower implementation level - not sure what is better 🤔 image

Added retry logic to the backend OCI push cmd

joshspicer
joshspicer previously approved these changes Aug 16, 2022
View reviewed changes
@joshspicer joshspicer mentioned this pull request Aug 16, 2022
Merged
alexdima
alexdima previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left one small comment.

joshspicer
joshspicer previously approved these changes Aug 17, 2022
View reviewed changes
@samruddhikhandale samruddhikhandale dismissed stale reviews from joshspicer and alexdima via b0be8ef August 17, 2022 16:10
@samruddhikhandale samruddhikhandale merged commit 405ed20 into main Aug 17, 2022
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/publish-features branch August 17, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

@alexdima alexdima alexdima left review comments

@chrmarti chrmarti Awaiting requested review from chrmarti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samruddhikhandale @alexdima @joshspicer