Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer sleep infinity to while sleep 1000 #275

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Prefer sleep infinity to while sleep 1000 #275

merged 2 commits into from
Aug 8, 2024

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Aug 7, 2024

Other templates seem to use sleep infinity, so why not do so here as well?

@r7kamura r7kamura requested a review from a team as a code owner August 7, 2024 04:42
samruddhikhandale
samruddhikhandale requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, left a minor comment

src/docker-existing-docker-compose/.devcontainer/docker-compose.yml Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ⚡

@samruddhikhandale samruddhikhandale merged commit b87588a into devcontainers:main Aug 8, 2024
2 checks passed
@r7kamura r7kamura deleted the docker-existing-sleep-infinity branch August 8, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r7kamura @samruddhikhandale