Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复dealloc方法移除通知时崩溃bug #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

修复dealloc方法移除通知时崩溃bug #76

wants to merge 1 commit into from

Conversation

zhangjk4859
Copy link

报错信息《Cannot remove an observer <AXWebViewController 0x106060200> for the key path estimatedProgress》

@devedbox
Copy link
Owner

devedbox commented Sep 1, 2018

存在这个问题吗？

@tentenlee100
Copy link
Contributor

tentenlee100 commented Sep 13, 2018 •
edited
Loading

@devedbox
有遇過這問題，當你把webview當作TabbarController的一個ViewController時會發生有還沒viewDidLoad所以KVO還沒建立，但要dealloc時就抓不到kvo的key就crash了，需要這個判斷。

只是這pr裡面還有改其他東西不只這些而已，我自己是在dealloc裡面加上try catch就可以解決了。

@tentenlee100
Copy link
Contributor

@devedbox
剛建立一個只修改這個問題的pr了

@zhangjk4859
Copy link
Author

存在这个问题吗？

是的，把AX当做tabbar的child view controller就会崩溃，需要在dealloc方法里加一个判断

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangjk4859 @devedbox @tentenlee100