Skip to content

fixed: all issues #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed: all issues #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85dd9f4
fixed: issue #1 and #2
antono91 Jun 27, 2023
52e38d0
fixed: issue #3, #4 and #5
antono91 Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<body>
<!-- Navbar -->
<!-- TODO: Fix Issue, Nav Buttons Don't Work (Desktop & Mobile) -->
<!-- TODO: Fix Issue, Nav Buttons Don't Work (Desktop & Mobile) done -->
<nav class="top">
<div class="bar blue card left-align large">
<a
Expand All @@ -22,16 +22,16 @@
title="Toggle Navigation Menu"
><i class="fa fa-bars"></i
></a>
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile done -->
<a id="nav-logo" href="#header" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" href="#challenges" class="bar-item button hide-small padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" href="#signup" class="bar-item button hide-small padding-large hover-white">Sign Up</a>
</div>

<!-- Navbar on small screens -->
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
<div id="mobile-nav" href="#header" class="bar-block white hide hide-large hide-medium large">
<a id="mobile-nav-challenges" href="#challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" href="#signup" class="bar-item button padding-large">Sign Up</a>
</div>
</nav>

Expand Down
13 changes: 13 additions & 0 deletions src/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,24 @@ addEventListener("submit", (event) => {

let email = document.getElementById("email").value;

userObject = usersTable.find(element => element["username"] == email)

if (userObject){
renderEmailTakenError();
} else if(email == "") {
renderEmailEmptyError();
} else {
renderSuccess();
usersTable.push({username: email})
}

// TODO: Show Correct Status Messages on Signup Form
// 1. successful signup
// 2. empty email
// 3. taken email
// 4. repeat email


});

let toggleNav = () => {
Expand Down
7 changes: 4 additions & 3 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,8 @@ form > span {

#jumbo-image {
max-height: 20rem;
/* TODO: Invert banner colors using CSS */
/* TODO: Invert banner colors using CSS done */
filter: invert(1);
}

@media (max-width: 600px) {
Expand Down Expand Up @@ -876,8 +877,8 @@ form > span {

#challenge-grid {
display: grid;
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
grid-template-columns: none;
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns done*/
grid-template-columns: 50% 50%;
grid-auto-rows: 10rem;
gap: 1rem;
padding-top: 2rem;
Expand Down