Skip to content

fixed: all issues #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fixed: all issues #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a02e36
fix navigation #1 & responsiveness #2
justnieto Jul 16, 2023
74badfa
fix invert #3
justnieto Jul 16, 2023
875a0a9
Fix #5 form logic
justnieto Jul 16, 2023
4b8734a
Fix nav and link
justnieto Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 71 additions & 16 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@
<meta charset="utf-8" />
<title>JobSimulator.Dev</title>
<link rel="stylesheet" href="styles.css" />
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lato" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" />
<link
rel="stylesheet"
href="https://fonts.googleapis.com/css?family=Lato"
/>
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"
/>
<script src="script.js"></script>
</head>

Expand All @@ -23,23 +29,57 @@
><i class="fa fa-bars"></i
></a>
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
<a
href="#header"
id="nav-logo"
class="bar-item button padding-large white"
>JobSimulator.Dev</a
>
<a
href="#challenges"
id="nav-challenges"
class="bar-item button padding-large hover-white hide-small"
>Browse Challenges</a
>
<a
href="#signup"
id="nav-signup"
class="bar-item button padding-large hover-white hide-small"
>Sign Up</a
>
</div>

<!-- Navbar on small screens -->
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
<div
id="mobile-nav"
class="bar-block white hide hide-large hide-medium large"
>
<a
href="#challenges"
id="mobile-nav-challenges"
class="bar-item button padding-large"
>Browse Challenges</a
>
<a
href="#signup"
id="mobile-nav-signup"
class="bar-item button padding-large"
>Sign Up</a
>
</div>
</nav>

<!-- Header -->
<header id="header" class="container white center" style="padding: 128px 16px">
<header
id="header"
class="container white center"
style="padding: 128px 16px"
>
<img id="jumbo-image" src="./banner-image.png" />
<h1 class="margin jumbo">Want to test your software dev skills?</h1>
<a href="#signup" class="button blue padding-large large margin-top">Sign Up</a>
<a href="#signup" class="button blue padding-large large margin-top"
>Sign Up</a
>
</header>

<section id="challenges" class="row-padding pink padding-256 container">
Expand All @@ -52,13 +92,22 @@ <h1>Browse Our Challenges</h1>
href="https://github.com/developer-job-simulation/vanilla-login-form"
>Vanilla Login Form</a
>
<a target="_blank" class="challenge-tile" href="https://github.com/developer-job-simulation/vanilla-table"
<a
target="_blank"
class="challenge-tile"
href="https://github.com/developer-job-simulation/vanilla-table"
>Vanilla Table</a
>
<a target="_blank" class="challenge-tile" href="https://github.com/developer-job-simulation/react-ecommerce"
<a
target="_blank"
class="challenge-tile"
href="https://github.com/developer-job-simulation/react-ecommerce"
>React Ecommerce</a
>
<a target="_blank" class="challenge-tile" href="https://github.com/developer-job-simulation/react-mui-table"
<a
target="_blank"
class="challenge-tile"
href="https://github.com/developer-job-simulation/react-mui-table"
>React Table</a
>
</div>
Expand All @@ -70,9 +119,15 @@ <h1>Browse Our Challenges</h1>
<div id="signup-form">
<h1>Sign Up & Get Started</h1>
<form>
<span id="success-message" class="success-message" hidden="true">Success!</span>
<span id="taken-error-message" class="error-message" hidden="true">Error: Email Already Taken</span>
<span id="empty-error-message" class="error-message" hidden="true">Error: Email Address Empty.</span>
<span id="success-message" class="success-message" hidden="true"
>Success!</span
>
<span id="taken-error-message" class="error-message" hidden="true"
>Error: Email Already Taken</span
>
<span id="empty-error-message" class="error-message" hidden="true"
>Error: Email Address Empty.</span
>
<input id="email" type="email" placeholder="Enter your email" />
<button>Submit</button>
</form>
Expand Down
16 changes: 16 additions & 0 deletions src/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,22 @@ addEventListener("submit", (event) => {
// 2. empty email
// 3. taken email
// 4. repeat email
let emailTaken = false;
// Loop through to check if already used, if so marks emailTaken true
usersTable.forEach((x) => {
if (x.username === email) {
emailTaken = true;
renderEmailTakenError();
}
});
// If email is empty render empty error
if (!email) {
renderEmailEmptyError();
} else if (!emailTaken) {
// If emailTaken false, add username object to array and render success
usersTable.push({ username: email });
renderSuccess();
}
});

let toggleNav = () => {
Expand Down
3 changes: 2 additions & 1 deletion src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ form > span {
#jumbo-image {
max-height: 20rem;
/* TODO: Invert banner colors using CSS */
filter: invert(1);
}

@media (max-width: 600px) {
Expand Down Expand Up @@ -877,7 +878,7 @@ form > span {
#challenge-grid {
display: grid;
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
grid-template-columns: none;
grid-template-columns: 1fr 1fr;
grid-auto-rows: 10rem;
gap: 1rem;
padding-top: 2rem;
Expand Down