Skip to content

Add haproxy_disable_restart variable #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stuwil
Copy link
Contributor

@stuwil stuwil commented Jan 26, 2018

Adds the haproxy_disable_restart (default: false) variable to conditionally skip the restart haproxy handler, for cases where this might not be wanted (e.g. a reload instead).

@r-daneel
Copy link
Collaborator

r-daneel commented Feb 9, 2018

I would suggest another approach:
Rename the notification from 'restart haproxy' to 'reload configuration'.
The handler would then use a variable named 'config_change_action' that could be 'reload', 'restart' or 'false' that would default to 'restart' (for backwards compatibility).
In this way, the user can choose the action instead of just having an all-or-nothing switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants