(FEAT): Added support for room multi-filtering #155
Conversation
…into 104-story-1-21-sorting-ui
…into 104-story-1-21-sorting-ui
…ilter sheet UI and UX
…v object for any viewModels, and refactored chain modifiers into readable modularised components
…into 104-story-1-21-sorting-ui
xleonx0x
left a comment
There was a problem hiding this comment.
The padding on your sheet heading isn't consistent between all the filters.
Some things that stick out:
Campus: You have an option for Any Campus, isn't this the same as not applying the filter at all? same with capacity, room type, duration you have clear options.
Duration: On iphone 16e ios 18 sim, the text looks squashed and distorted on the picker
Capacity: I don't really like the option to add your own capacity kinda defeats the purpose of the radio buttons? I'd change it to a slider if you want them to be able to specify exactly the amount.
There's no padding involved when dealing with sheets, it's the sizing of the sheet that makes it look inconsistent. sure I can change the sizing of each sheet but I need to manually check each and then compare for all, not ideal workflow. Duration: I'll remove the font modifier that i tried to enlarge the slider. |
|
6 7 |
@avdn-dev wdyt? |
Just had crunch time at work, will look at this tomorrow |
|
…into 104-story-1-21-sorting-ui
|
Will revamp this PR as we’ve managed to reverse engineer Freerooms’ backend endpoints, allowing us to migrate the filtering logic server-side and better align with the existing API structure. |
…into 104-story-1-21-sorting-ui
…-unsw/freerooms-mobile into 104-story-1-21-sorting-ui
What
RoomsTabViewandBuildingsTabViewinto smaller view sections/bindings to reduce SwiftUI type-check complexity.Why
How
FilterBarintegration in Rooms with an anchored floating menu near the tab bar.swiftlint --force-excludebehavior with explicit exclusion rules for.build/checkout paths.Key checks:
Automated tests:
Manual tests:
Screenshot / Recording
Capacity Filter:

Campus Filter:

Room Type Filter:
Duration Filter:

Date Filter:
