Conversation
…making mock http responses
…hing room filtered by a set of filter conditions
…related comments Co-authored-by: Copilot <[email protected]>
xleonx0x
reviewed
Apr 26, 2026
Contributor
xleonx0x
left a comment
There was a problem hiding this comment.
lgtm, just fix those small things e
| @@ -0,0 +1,159 @@ | |||
| // | |||
| // File.swift | |||
xleonx0x
previously approved these changes
Apr 26, 2026
xleonx0x
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrated room filtering from client-side logic to the existing backend room search API.
This PR adds a
LiveFilterRoomLoaderservice that builds a filtered GET request to/api/rooms/search, decodes the returned room map, and extracts the matching room IDs for the app to use when displaying filtered room results.Why
The app previously relied on filtering room data on-device, which duplicated logic that already exists in the backend and could become inefficient as the room dataset grows.
Using the backend search endpoint keeps the mobile app aligned with the established API behaviour and avoids maintaining complex filtering logic on the client.
How
datetime,buildingId,capacity,duration,usage,location,startTime, andendTime.Key checks:
Automated tests:
Manual tests:
Screenshot / Recording
N/A