chore(deps): update dependency next-auth to v4.24.12 [security] - abandoned#259
Open
renovate[bot] wants to merge 12 commits into
Open
chore(deps): update dependency next-auth to v4.24.12 [security] - abandoned#259renovate[bot] wants to merge 12 commits into
renovate[bot] wants to merge 12 commits into
Conversation
Contributor
Author
Branch automerge failureThis PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead. |
8dd37ca to
4206d8b
Compare
8b1ba10 to
8c10321
Compare
2fc169e to
12a9fea
Compare
f403122 to
39e6e1d
Compare
740323b to
77cbeb0
Compare
7c0dbcc to
84e19b7
Compare
78b86ef to
ea26f8c
Compare
b5b4c53 to
38472ef
Compare
38472ef to
bfeb515
Compare
a6f5fa1 to
42ee590
Compare
42ee590 to
30f5fbc
Compare
30f5fbc to
198f19d
Compare
7a23eab to
ba66669
Compare
added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js
ba66669 to
ffb0d5a
Compare
* added link icon and clickable course code to bookmarked reviews * Make bookmarked review titles clickable, added link icon * added clickable course code to card view of bookmarked reviews --------- Co-authored-by: Annelise Koh <afekoh1559@gmail.com>
ffb0d5a to
3dcaee0
Compare
…rked reviews (#362) * colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com> * fixed card/list toggle only for when there are user reviews and user bookmarked reviews * removed extra file --------- Co-authored-by: alecliu1204 <111400188+alecliu1204@users.noreply.github.com> Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com> Co-authored-by: Lyn Duong <z5585295@ad.unsw.edu.au>
* colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com> * added hover colouring to bookmarked cards --------- Co-authored-by: alecliu1204 <111400188+alecliu1204@users.noreply.github.com> Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com> Co-authored-by: Lyn Duong <z5585295@ad.unsw.edu.au>
3dcaee0 to
2a2cdfb
Compare
* added link icon and clickable course code to bookmarked reviews * Make bookmarked review titles clickable, added link icon * added clickable course code to card view of bookmarked reviews * made link icon smaller and moved it to the right of course code --------- Co-authored-by: Annelise Koh <afekoh1559@gmail.com> Co-authored-by: alecliu1204 <111400188+alecliu1204@users.noreply.github.com>
2a2cdfb to
5328d52
Compare
* Added animation to modal popup for Filter * colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com> * Fixed filter animation and padding * Fixed text only review always --------- Co-authored-by: alecliu1204 <111400188+alecliu1204@users.noreply.github.com> Co-authored-by: Auston Yang <163545426+ajzombie123@users.noreply.github.com>
5328d52 to
3b496e9
Compare
changed dimensions of modal and made centered in viewport excluding navbar
3b496e9 to
2da1a24
Compare
2da1a24 to
864a3b2
Compare
864a3b2 to
40da829
Compare
* added skeleton for new landingpage and course library pages * created components for landing page * completed new UI sponsors component (#371) * finished base structure of sponsors for dark mode * finished darkmode component * added dark and light mode logos * fixed border colouring for light mode * finalised styling of spacing and font bolding * finished new header component for landing page * header, sponsors and course pages ready * Began creating Features Page. Created divs and added Roboto font * Created Features Page and left svg files in Assets * done with draft of new ui --------- Co-authored-by: Rokika Kh <rokika.kh1@gmail.com> Co-authored-by: l-duong05 <176846912+l-duong05@users.noreply.github.com> Co-authored-by: l-duong05 <lduong05.git@gmail.com> Co-authored-by: William Lu <williamlu2016@gmail.com>
40da829 to
2f17d26
Compare
* added skeleton for new landingpage and course library pages * created components for landing page * completed new UI sponsors component (#371) * finished base structure of sponsors for dark mode * finished darkmode component * added dark and light mode logos * fixed border colouring for light mode * finalised styling of spacing and font bolding * finished new header component for landing page * header, sponsors and course pages ready * Began creating Features Page. Created divs and added Roboto font * Created Features Page and left svg files in Assets * done with draft of new ui * rearranged routes for new UI. added footer --------- Co-authored-by: Rokika Kh <rokika.kh1@gmail.com> Co-authored-by: l-duong05 <176846912+l-duong05@users.noreply.github.com> Co-authored-by: l-duong05 <lduong05.git@gmail.com> Co-authored-by: William Lu <williamlu2016@gmail.com>
2f17d26 to
93d3054
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.22.1→4.24.12GitHub Vulnerability Alerts
CVE-2023-48309
Impact
next-authapplications prior to version 4.24.5 that rely on the default Middleware authorization are affected.A bad actor could create an empty/mock user, by getting hold of a NextAuth.js-issued JWT from an interrupted OAuth sign-in flow (state, PKCE or nonce).
Manually overriding the
next-auth.session-tokencookie value with this non-related JWT would let the user simulate a logged in user, albeit having no user information associated with it. (The only property on this user is an opaque randomly generated string).This vulnerability does not give access to other users' data, neither to resources that require proper authorization via scopes or other means. The created mock user has no information associated with it (ie. no name, email, access_token, etc.)
This vulnerability can be exploited by bad actors to peek at logged in user states (e.g. dashboard layout).
Note: Regardless of the vulnerability, the existence of a NextAuth.js session state can provide simple authentication, but not authorization in your applications. For role-based access control, you can check out our guide.
Patches
We patched the vulnerability in
next-authv4.24.5. To upgrade, run one of the following:Workarounds
Upgrading to
latestis the recommended way to fix this issue. However, using a custom authorization callback for Middleware, developers can manually do a basic authentication:References
GHSA-5jpx-9hw9-2fx4
Summary
NextAuth.js's email sign-in can be forced to deliver authentication emails to an attacker-controlled mailbox due to a bug in
nodemailer's address parser used by the project (fixed innodemailerv7.0.7). A crafted input such as:is parsed incorrectly and results in the message being delivered to
e@attacker.com(attacker) instead of"<e@attacker.com>@​victim.com"(the intended recipient atvictim.com) in violation of RFC 5321/5322 semantics. This allows an attacker to receive login/verification links or other sensitive emails intended for the victim.Affected NextAuthjs Version
POC
Example Setup showing misdelivery of email
Mitigation
Update to nodemailer 7.0.7
Credits
https://zeropath.com/ Helped identify this security issue
Release Notes
nextauthjs/next-auth (next-auth)
v4.24.12Compare Source
v4.24.11Compare Source
v4.24.10Compare Source
What's Changed
490a033Full Changelog: https://github.com/nextauthjs/next-auth/compare/next-auth@4.24.9...next-auth@4.24.10
v4.24.9Compare Source
What's Changed
awaitdynamic APIs as per Next.js 15 changes by @balazsorban44 in4d143c5New Contributors
Full Changelog: https://github.com/nextauthjs/next-auth/compare/next-auth@4.24.8...next-auth@4.24.9
v4.24.8Compare Source
What's Changed
identifier@auth/*-adaptersfor v4 by @balazsorban44 in #11562New Contributors
Full Changelog: https://github.com/nextauthjs/next-auth/compare/next-auth@4.24.7...next-auth@4.24.8
v4.24.7Compare Source
Others
v4.24.6Compare Source
Bugfixes
nodemailerimports (#9261) (fa287be)v4.24.5Compare Source
Bugfixes
v4.24.4Compare Source
Bugfixes
v4.24.3Compare Source
Bugfixes
v4.24.2Compare Source
Bugfixes
v4.24.1Compare Source
Bugfixes
v4.24.0Compare Source
Features
v4.23.2Compare Source
Bugfixes
redirect: falsefor route handler (#8775) (27b2519)d813c00)?from signIn URL (#8466)Other
v4.23.1Compare Source
Bugfixes
next-auth/adapters(20c3fe3)defaultsubmodules export inpackage.json(#8330)v4.23.0Compare Source
Features
5a8aa2e)Bugfixes
05ff6ae)v4.22.5Compare Source
Bugfixes
next-auth/adapter&@auth/core/adapters(3b0128c)Other
v4.22.4Compare Source
Bugfixes
465644f)getServerSession(#8108)res.end()in api handler (#8244)Other
getServerSessionunstable_getServerSessionv4.22.3Compare Source
Full Changelog: https://github.com/nextauthjs/next-auth/compare/next-auth@4.22.2...next-auth@4.22.3
v4.22.2Compare Source
Bugfixes
nodemailer/required types (#7950) (f48eb04)bd37c55)169a523)Other
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.