-
Notifications
You must be signed in to change notification settings - Fork 55
feat: Deployment Without Approval (Exception) #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added check for CD
…/deployment-exception
…ap in trigger view
…/deployment-exception
…/deployment-exception
add tooltip to merge strategy label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/ApplicationGroup/Details/TriggerView/BulkCDTrigger.tsx:543
Need to set isExceptionUser here as well
src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was unable to request changes so left dummy comment
…/deployment-exception
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2042
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: