Skip to content

feat: Deployment Without Approval (Exception) #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 5, 2025

Conversation

RohitRaj011
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2042

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@RohitRaj011 RohitRaj011 self-assigned this Apr 8, 2025
@github-actions github-actions bot added the PR:Ready-to-Review PR:Ready-to-Review label Apr 8, 2025
Copy link
Member

@AbhishekA1509 AbhishekA1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/ApplicationGroup/Details/TriggerView/BulkCDTrigger.tsx:543

Need to set isExceptionUser here as well

Copy link
Member

@AbhishekA1509 AbhishekA1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was unable to request changes so left dummy comment

AbhishekA1509
AbhishekA1509 previously approved these changes Apr 24, 2025
vivek-devtron
vivek-devtron previously approved these changes May 5, 2025
Copy link

sonarqubecloud bot commented May 5, 2025

@RohitRaj011 RohitRaj011 merged commit a8312d9 into develop May 5, 2025
10 checks passed
@RohitRaj011 RohitRaj011 deleted the feat/deployment-exception branch May 5, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants