feat: Remove config and deployment notifocation approval from dashboard#3071
Closed
shivani170 wants to merge 27 commits into
Closed
feat: Remove config and deployment notifocation approval from dashboard#3071shivani170 wants to merge 27 commits into
shivani170 wants to merge 27 commits into
Conversation
- Created SecurityScansTabCellComponents.tsx for custom cell rendering - Created service.ts with getSecurityScans function for Table getRows - Created SecurityScansTableWrapper.tsx to handle filters and UI around Table - Updated utils.tsx with column configuration and comparators - Refactored SecurityScansTab.tsx to use Table component from devtron-fe-common-lib Co-authored-by: Elessar1802 <66767648+Elessar1802@users.noreply.github.com>
- Move scanDetails state to parent SecurityScansTab component - Pass scanDetails and setScanDetails to SecurityScansTableWrapper - Remove unused useState from wrapper component - Properly handle row click for both scanned and not-scanned items Co-authored-by: Elessar1802 <66767648+Elessar1802@users.noreply.github.com>
- Removed AppIconCellComponent from SecurityScansTabCellComponents.tsx - Removed empty icon column from column configuration - Added rowStartIconConfig prop to Table component with ic-devtron-app icon - Simplified column definitions to start with APP NAME Co-authored-by: Elessar1802 <66767648+Elessar1802@users.noreply.github.com>
Co-authored-by: Elessar1802 <66767648+Elessar1802@users.noreply.github.com>
…omponent Co-authored-by: Elessar1802 <66767648+Elessar1802@users.noreply.github.com>
…/installation-env-list
feat: use table in security vulnerabilities list
shivani170
requested review from
vikramdevtron and
vivek-devtron
as code owners
feat: replace job list with table component
chore: bump common version
shivani170
changed the title
shivani170
changed the title
shivani170
changed the title
shivani170
changed the title
|
pawan-mehta-dt
changed the title
Contributor
Author
|
#3074 This is the new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2851
Type of change
Checklist: