Skip to content

feat: add Assume Role ARN field for cross-account ECR registries#3085

Merged
abhibhaw merged 5 commits into
release-candidate-v0.46.0from
feat/ecr-cross-account-assume-role
Apr 15, 2026
Merged

feat: add Assume Role ARN field for cross-account ECR registries#3085
abhibhaw merged 5 commits into
release-candidate-v0.46.0from
feat/ecr-cross-account-assume-role

Conversation

@abhibhaw

@abhibhaw abhibhaw commented Mar 31, 2026

Copy link
Copy Markdown
Member

Added assumeRoleArn to the ECR registry form and API payload, allowing users to configure cross-account ECR access via STS AssumeRole. The field is available for both EC2 IAM Role and User auth modes.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2868

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Added assumeRoleArn to the ECR registry form and API payload, allowing
users to configure cross-account ECR access via STS AssumeRole. The
field is available for both EC2 IAM Role and User auth modes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 31, 2026 08:53
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for configuring cross-account AWS ECR access by introducing an optional Assume Role ARN field in the container registry (ECR) configuration UI and including it in the registry payload sent to the backend.

Changes:

  • Extended RegistryPayloadType to include an optional assumeRoleArn.
  • Plumbed assumeRoleArn through the Docker registry list → form props/state → API payload construction.
  • Added an ECR-only form input for “Assume Role ARN (cross-account)” (shown for both EC2 IAM Role and User auth modes, and only for private ECR storage mode).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/config/constants.ts Adds assumeRoleArn?: string to the registry payload type.
src/components/dockerRegistry/Docker.tsx Adds form state + UI field for AssumeRole ARN and includes it in the ECR payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AbhishekA1509
AbhishekA1509 previously approved these changes Mar 31, 2026
@AbhishekA1509 AbhishekA1509 changed the title feat(ecr): add Assume Role ARN field for cross-account ECR registries feat: add Assume Role ARN field for cross-account ECR registries Mar 31, 2026
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions Bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Apr 15, 2026
@AbhishekA1509 AbhishekA1509 changed the base branch from develop to release-candidate-v0.46.0 April 15, 2026 10:42
@sonarqubecloud

Copy link
Copy Markdown

@abhibhaw abhibhaw merged commit 3b8ec70 into release-candidate-v0.46.0 Apr 15, 2026
6 checks passed
@abhibhaw abhibhaw deleted the feat/ecr-cross-account-assume-role branch April 15, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants