Skip to content

fix: helm app hibernate #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunjaindev merged 2 commits into from
Apr 13, 2026
Merged

fix: helm app hibernate #3091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ac05a
fix: helm app hibernate
arunjaindev Apr 9, 2026
0d23f73
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
arunjaindev Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,12 @@ src/components/ClusterNodes/ClusterEvents.tsx
src/components/ClusterNodes/ClusterManifest.tsx
src/components/ClusterNodes/ClusterNodeEmptyStates.tsx
src/components/ClusterNodes/NodeDetails.tsx
src/components/Hotjar/Hotjar.tsx
src/components/Jobs/ExpandedRow/ExpandedRow.tsx
src/components/Jobs/JobDetails/JobDetails.tsx
src/components/Jobs/JobsEmptyState.tsx
src/components/Jobs/Service.ts
src/components/Jobs/Utils.ts
src/components/LogViewer/LogViewer.tsx
src/components/__mocks__/xterm-webfont.js
src/components/app/LogFilter.ts
src/components/app/Overview/EnvironmentList.tsx
src/components/app/Overview/Overview.tsx
Expand Down
19 changes: 0 additions & 19 deletions src/components/__mocks__/xterm-webfont.js
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions src/components/v2/appDetails/sourceInfo/EnvironmentSelector.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,10 +287,7 @@ const EnvironmentSelectorComponent = ({
isExternalFlux ||
isExternalArgo
) && (
<div
data-testid="dot-button-app-details"
className="ml-8"
>
<div data-testid="dot-button-app-details" className="ml-8">
<ActionMenu
id="cluster-action-menu"
onClick={handleActionMenuClick}
Expand Down Expand Up @@ -360,11 +357,7 @@ const EnvironmentSelectorComponent = ({
/>
)}
{showWorkloadsModal && (
<ScaleWorkloadsModal
appId={appIdentifier}
onClose={() => setShowWorkloadsModal(false)}
history={history}
/>
<ScaleWorkloadsModal appId={appIdentifier} onClose={() => setShowWorkloadsModal(false)} />
)}
</div>
)
Expand Down
7 changes: 5 additions & 2 deletions src/components/v2/appDetails/sourceInfo/scaleWorkloads/ScaleWorkloadsModal.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@
import IndexStore from '../../index.store'
import { AppType } from '../../appDetails.type'
import { getInstalledChartDetailWithResourceTree } from '../../appDetails.api'
import { useLocation, useNavigate } from 'react-router-dom'

export default function ScaleWorkloadsModal({ appId, onClose, history }: ScaleWorkloadsModalProps) {
export default function ScaleWorkloadsModal({ appId, onClose }: ScaleWorkloadsModalProps) {

Check warning on line 49 in src/components/v2/appDetails/sourceInfo/scaleWorkloads/ScaleWorkloadsModal.component.tsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 


See more on https://sonarcloud.io/project/issues?id=devtron-labs_dashboard&issues=AZ1xOGwDy10cRilH_aU9&open=AZ1xOGwDy10cRilH_aU9&pullRequest=3091
const navigate = useNavigate()
const { pathname } = useLocation()
const [nameSelection, setNameSelection] = useState<Record<string, WorkloadCheckType>>({
scaleDown: {
isChecked: false,
Expand Down Expand Up @@ -331,7 +334,7 @@

setFetchingLatestDetails(true)
_setWorkloadsList(_workloadsList)
history.push(`${history.location.pathname}?refetchData=true`)
navigate(`${pathname}?refetchData=true`)
}
await _getAndSetAppDetail()
} catch (e) {
Expand Down
1 change: 0 additions & 1 deletion src/components/v2/appDetails/sourceInfo/scaleWorkloads/scaleWorkloadsModal.type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export interface ScaleWorkloadsType extends HibernateTargetObject, WorkloadCheck
export interface ScaleWorkloadsModalProps {
appId: string
onClose: () => void
history: any
}

export interface HibernateTargetObject {
Expand Down
Loading