Skip to content

fix: dependabot issues and node version#3092

Merged
AbhishekA1509 merged 24 commits into
developfrom
chore/main-sync
Apr 15, 2026
Merged

fix: dependabot issues and node version#3092
AbhishekA1509 merged 24 commits into
developfrom
chore/main-sync

Conversation

@AbhishekA1509

@AbhishekA1509 AbhishekA1509 commented Apr 9, 2026

Copy link
Copy Markdown
Member

Description

This pull request introduces several significant updates focused on modernizing dependencies, refactoring terminal-related components to use the latest xterm ecosystem, and improving error handling and navigation in the application. The most notable changes include upgrading Node.js and related packages, replacing deprecated or legacy xterm packages with the new @xterm scoped packages, refactoring terminal integration code, and enhancing user experience with better error messages and navigation logic.

Dependency and Environment Upgrades:

  • Upgraded Node.js version from v22 to v24.14.1 in .nvmrc and updated the Dockerfile to use node:24-alpine for the build environment. [1] [2]
  • Updated several dependencies in package.json, including switching from legacy xterm packages to @xterm/xterm and @xterm/addon-fit, updating dompurify, yaml, and bumping vite and related overrides to 8.0.8. [1] [2] [3] [4]

Terminal Integration Refactor:

  • Refactored terminal components (ClusterTerminal.tsx and LogViewer.component.tsx) to use the new @xterm/xterm and @xterm/addon-fit packages, removing legacy add-ons and mocks, and updating import paths for terminal CSS. [1] [2] [3] [4]
  • Replaced the deprecated registerLinkMatcher with the new registerLinkProvider API for clickable links in the terminal, improving maintainability and compatibility. [1] [2]
  • Simplified and cleaned up the log viewer component by removing unused features (such as search and webfont add-ons), streamlining the code, and ensuring proper resource cleanup. [1] [2]

Error Handling and User Experience Improvements:

  • Enhanced error handling in CreateResource.tsx to show user-friendly toast notifications for permission-denied errors, improving feedback for access issues. [1] [2] [3]
  • Improved navigation in the application list by making the app name cell use a redirectToAppDetails function, allowing for more flexible and accurate routing. [1] [2] [3] [4]

Code and File Cleanup:

  • Removed the unused mock for xterm-webfont and updated .eslintignore to reflect these changes. [1] [2]
  • Corrected a minor SCSS issue by removing an invalid border-radius value in ContentCard.scss.

Minor Fixes:

  • Improved log parsing resilience in grepSSEworker.ts to handle cases where result.content may be undefined.
  • Removed an unused state variable related to log highlighting in Logs.component.tsx.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2879

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 self-assigned this Apr 9, 2026
@github-actions github-actions Bot added the PR:Ready-to-Review PR:Ready-to-Review label Apr 9, 2026
vivek-devtron
vivek-devtron previously approved these changes Apr 9, 2026
@AbhishekA1509 AbhishekA1509 changed the title chore: main sync fix: dependabot issues and node version Apr 10, 2026
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions Bot added PR:Issue-verification-failed PR:Issue-verification-failed and removed PR:Ready-to-Review PR:Ready-to-Review labels Apr 10, 2026
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud

Copy link
Copy Markdown

@github-actions github-actions Bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Apr 15, 2026
@AbhishekA1509 AbhishekA1509 merged commit 8f83d7c into develop Apr 15, 2026
11 of 12 checks passed
@AbhishekA1509 AbhishekA1509 deleted the chore/main-sync branch April 15, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants