feat: custom plugin condition details#3096
Merged
Merged
Conversation
…ils and updating related utilities
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
1 similar comment
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
arunjaindev
previously approved these changes
Apr 21, 2026
arunjaindev
approved these changes
Apr 21, 2026
|
vivek-devtron
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This pull request introduces significant enhancements to how plugin condition details and variables are handled in the CI Pipeline plugin modal and related utilities. The main improvements include extracting and associating plugin condition details with input/output variables, updating payload construction logic to include these details, and improving type definitions to support the new structure. These changes improve the accuracy and flexibility of plugin configuration and condition handling.
Enhancements to plugin variable and condition handling:
getConditionDetailsAndVariablesFromPluginto extract condition details and clean variable lists from plugin input/output variables. This is used in both the plugin modal and pre-build step to ensure condition details are correctly associated and passed. [1] [2] [3] [4]Improvements to payload construction and variable parsing:
parseInputVariablesIntoCreatePluginPayloadto include associated condition details and additional properties (valueConstraint,isRuntimeArg,pluginStepCondition) when available, improving the fidelity of plugin step payloads. [1] [2] [3]getCreatePluginPayloadto split condition details into input and output categories using a new utility, and to pass the correct set of conditions to each variable list. [1] [2]Type and dependency updates:
pluginStepCondition,valueConstraint,isRuntimeArg) on plugin step variable items, and imported additional types as needed. [1] [2] [3] [4]@devtron-labs/devtron-fe-common-libto version1.23.5-beta-2inpackage.jsonto ensure compatibility with new types and features.New utility for condition detail categorization:
getInputOutputConditionDetailsincdpipeline.util.tsxto categorize condition details as input or output based on their type, supporting more precise payload construction.These changes collectively make plugin step configuration more robust and maintainable, especially regarding the handling of complex condition logic.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2880
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: