Tidyverse support #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 55ebd0d.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 95.83% 96.12% +0.28%
==========================================
Files 17 17
Lines 1153 1238 +85
==========================================
+ Hits 1105 1190 +85
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nning but i need the graphics tonight!
…et_icd_codes() which prevents a deep copy
…ble since tibble is imported by dplyr
Prior to this change requireNamespace set a variable. This worked on my machine but failed in GitHub Actions. - tests/test-data-frame-tools.R: mdcr_inner_join() on a tibble input is returning something that isn’t identical to the expected tibble. - tests/test-tibble-datatable.R: for a data.table input, comorbidities() is returning something that isn’t a data.table (data.table::is.data.table(DTS[[obj]]) is FALSE). Both symptoms are exactly what you’d get if the package was loaded with ..mdcr.dplyr.aware.. and ..mdcr.datatable.aware.. set to FALSE, so the joins fall back to base merge() and the comorbidity pipeline runs through the data.frame code paths, even though dplyr/data.table are actually installed later in the session. In your workflow, r-lib installs Suggests (data.table/dplyr show up in the log), but if the namespace was loaded before those Suggests were on the library path (or under _R_CHECK_DEPENDS_ONLY_), those flags would be locked to FALSE for the rest of the session, giving exactly these test failures. This commit reverts to using requireNamespace() to prevent this from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.