Fix deepMerge for array of tool objects
#42
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that the `deepMerge` function can handle merging arrays of tool objects.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@colelawrence this fixes the most basic case that is meant more as a demonstration. This will merge the tool objects based on order, which almost definitely isn't what we want. We probably want a smarter merge by function name for cases where they aren't in the same order. |
Contributor
|
@CharlieHelps this is a test |
|
Hi @stevepeak, thanks for the test! I'm here and listening. (Message from charlie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the
deepMergefunction can handle merging arrays of tool objects.Resolves #40