Add core dependency to examples
#1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
force-pushed
the
core-package-examples
branch
from
9ab3c38 to
a4b801c
Compare
letmejustputthishere
approved these changes
Aug 15, 2025
|
Good to know about the example list; thanks! The current diff should cover all of them including nft-creator? Looks like it's just in a different order in the CI workflow. Waiting for 1.0.0 release and then should be ready to merge once we get the remaining approval. |
THLO
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use the new Motoko standard library (
core) package in parallel withbase, primarily for editing the examples on ICP Ninja.We eventually want to fully convert these examples to use
core(see #1244).