feat: Collapsible content new prop to avoid overflow hidden #603
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddecentage
changed the title
…verflow-hidden' into feat/collapsible-content-avoid-overflow-hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to some issues with borders and outlines being cut for collapsible content, I added the possibility to apply an offset to be able to avoid content being cut off.
Changes
offsetContentprop to collapsible component.offset-contentfor normal collapsibles.offset-content-scrollfor when maxContentHeight is specified as well, because the margins behave a bit differently when content is scrollable (which can only happen if maxContentHeight is set)Screenshots
In the screenshot we can see that the closed state is not affected, and the black outline is visible by setting
offsetContentproperty.