chore: Revert unnecessary xnet_slo_120_subnets_staging_test mitigation#10620
Open
alin-at-dfinity wants to merge 1 commit into
Open
chore: Revert unnecessary xnet_slo_120_subnets_staging_test mitigation#10620alin-at-dfinity wants to merge 1 commit into
xnet_slo_120_subnets_staging_test mitigation#10620alin-at-dfinity wants to merge 1 commit into
Conversation
Commit d2483fa applied a number of mitigations addressing xnet_slo_120_subnets_staging_test flakiness. Some of these still make sense (reduced timeouts, using select_all()), but now that the test is reliably passing, we should ideally go back to covering both best-effort and guaranteed-response calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d2483fa applied a number of mitigations addressing
xnet_slo_120_subnets_staging_testflakiness. Some of these still make sense (reduced timeouts, usingselect_all()), but now that the test is reliably passing, we should ideally revert to covering both best-effort and guaranteed-response calls.