Skip to content

chore: bump secp256k1-sys and bitcoin#10649

Open
nmattia wants to merge 1 commit into
masterfrom
nm-secp-btc-bump
Open

chore: bump secp256k1-sys and bitcoin#10649
nmattia wants to merge 1 commit into
masterfrom
nm-secp-btc-bump

Conversation

@nmattia

@nmattia nmattia commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This bumps some crates and allows us to remove some duplication in the lockfile.

This bumps some crates and allows us to remove some duplication in the
lockfile.
@nmattia nmattia requested review from a team as code owners July 3, 2026 12:39
@github-actions github-actions Bot added the chore label Jul 3, 2026
@zeropath-ai

zeropath-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 4eac441.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► packages/ic-secp256k1/Cargo.toml
    Update secp256k1 and Bitcoin crate versions for dev-dependencies; adjust features
► packages/ic-secp256k1/tests/tests.rs
    Update Bitcoin library usage and API calls in tests
► packages/ic-secp256k1/BUILD.bazel
    Update crate dependency references from bitcoin-0.28.2 to bitcoin_dogecoin and adjust related references
► bazel/rust.MODULE.bazel
    Update crate spec version for secp256k1-sys and adjust features
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/BUILD.bazel
    Switch dependency from bitcoin_0_28 to bitcoin_dogecoin
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/Cargo.toml
    Update dependencies to bitcoin = workspace and secp256k1 = 0.29 with updated features
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/src/lib.rs
    Adapt code to new bitcoin crate API (TapNodeHash, from_digest_slice, to_x_only_public_key) and verification calls
► rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils/BUILD.bazel
    Adjust TODO and bitcoin reference to bitcoin_dogecoin
► Cargo.lock and related lock files
    Bump various crates, notably windows-sys from 0.59.0/0.60.x to 0.61.2, and update numerous dependencies accordingly
► Cargo.Bazel.toml.lock and Cargo.Bazel.json.lock
    Reflect updated dependency versions for secp256k1, windows-sys, and related crates
► bzl/module adjustments

@nmattia nmattia enabled auto-merge July 3, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants