chore: cargo clippy fixes to prepare for the rustc upgrade: 1.95.0 -> 1.97.0

[basvandijk]

cargo clippy fixes to prepare for upgrading to rustc-1.97.0.

[github-actions]

Run URL: https://github.com/dfinity/ic/actions/runs/29120192331

New container images with tag: 180b7a18c045f013033db88ee52d44c4c9f1b7f3f51ba132ab53ded517d492da
ic-build: sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e
ic-dev: sha256:7f4e0bb317291ee52f3a74e7228590582222e29f7ccd6adc353678a90a8549f4

[Copilot]

Pull request overview

This PR performs mechanical Rust code cleanups and dependency/lockfile updates as preparatory work for upgrading the toolchain from rustc 1.95.0 to 1.97.0, largely by removing redundant borrows and adopting newer/clearer std patterns.

Changes:

• Remove unnecessary & borrows in formatting / Display / logging code across the Rust workspace.
• Simplify Option/map iteration logic using filter, values_mut(), keys(), and ? where appropriate.
• Update ethnum to 1.5.3 and refresh Cargo/Bazel lockfiles to match the new dependency graph.

Reviewed changes

Copilot reviewed 60 out of 63 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
rs/types/types/src/crypto/threshold_sig/ni_dkg/errors/key_removal_error.rs	Remove redundant borrow in Display formatting.
rs/types/types/src/crypto/threshold_sig/ni_dkg/errors.rs	Remove redundant borrow when formatting internal error.
rs/types/types/src/crypto/threshold_sig/ni_dkg/config.rs	Remove redundant borrow in Display formatting.
rs/types/types/src/crypto/threshold_sig/ni_dkg.rs	Remove redundant borrows in Display formatting for NI-DKG types.
rs/types/types/src/crypto/error.rs	Remove redundant borrows in multiple Display impls / formatting args.
rs/types/types/src/consensus/idkg.rs	Remove redundant borrow in Display formatting.
rs/types/management_canister_types/src/lib.rs	Remove redundant borrows in Display output for install args structs.
rs/tests/driver/src/driver/logs_stream_task.rs	Remove redundant borrows in error-context formatting.
rs/tests/driver/src/driver/farm.rs	Remove redundant borrow in request path formatting.
rs/tests/crypto/rpc_csp_vault_reconnection_test.rs	Remove redundant borrows in systemd command formatting.
rs/tests/boundary_nodes/integration_test_common/src/lib.rs	Adjust formatting arguments for expected byte arrays in failure messages.
rs/test_utilities/execution_environment/src/lib.rs	Simplify map iteration using values_mut().
rs/state_manager/src/state_sync/types.rs	Simplify Option handling using ? and remove redundant branching.
rs/state_layout/src/state_layout.rs	Remove redundant borrows in temp-path formatting.
rs/sns/governance/src/proposal.rs	Remove redundant borrows in rendered text formatting.
rs/sns/governance/src/icrc_ledger_helper.rs	Remove redundant borrow in error formatting.
rs/sns/governance/src/extensions.rs	Remove redundant borrow in string formatting.
rs/sns/cli/src/deploy.rs	Remove redundant borrows in printing/formatting and JSON write path.
rs/rust_canisters/canister_test/src/canister.rs	Remove redundant borrows in retry/install logging.
rs/rosetta-api/icp/src/request_handler.rs	Remove redundant borrow in invalid-address error formatting.
rs/rosetta-api/common/rosetta_core/src/identifiers.rs	Remove redundant borrows in conversion error contexts.
rs/replica/bin/replica/main.rs	Remove redundant borrows in profiler report logging.
rs/replay/src/player.rs	Remove redundant borrows in output/log formatting.
rs/replay/src/backup.rs	Remove redundant borrow in invalid-artifact logging.
rs/registry/nns_data_provider/src/registry.rs	Remove redundant borrow when formatting agent in error path.
rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs	Remove redundant borrows in logging/panic formatting.
rs/registry/canister/src/invariants/endpoint.rs	Remove redundant borrows in invariant error formatting.
rs/registry/admin/bin/main.rs	Remove redundant borrows in proposal title/payload printing.
rs/prep/src/internet_computer.rs	Simplify map iteration with values_mut() for node operator assignment.
rs/orchestrator/src/catch_up_package_provider.rs	Remove redundant borrow in IO error formatting.
rs/nns/test_utils/src/registry.rs	Remove redundant borrow in panic message formatting.
rs/nns/test_utils/src/gtc_helpers.rs	Remove redundant borrow in seed logging.
rs/nns/governance/src/neuron_data_validation.rs	Simplify Option handling with ? for known neuron name extraction.
rs/nns/governance/src/governance.rs	Remove redundant borrow in debug-format string creation.
rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs	Remove redundant borrows in assert/panic formatting.
rs/interfaces/src/execution_environment/errors.rs	Remove redundant borrows in error description formatting.
rs/ic_os/networking/network/src/systemd.rs	Remove redundant borrows; simplify IPv6 address formatting.
rs/ic_os/networking/network/src/interfaces.rs	Remove redundant borrows in logging.
rs/ic_os/build_tools/dflate/src/main.rs	Remove redundant borrow in invalid-path error message.
rs/execution_environment/src/scheduler.rs	Simplify Option logic using filter for non-zero resource limit.
rs/execution_environment/src/execution_environment.rs	Remove redundant borrows in canister-not-found error formatting.
rs/execution_environment/src/canister_manager/types.rs	Remove redundant borrow in error formatting.
rs/ethereum/cketh/minter/src/map.rs	Simplify iteration over map keys to avoid unused tuple elements.
rs/embedders/src/wasm_utils/validation.rs	Remove redundant borrow in validation error formatting.
rs/crypto/src/vetkd/mod.rs	Remove redundant borrow in internal error formatting.
rs/crypto/sha2/src/context/mod.rs	Remove redundant borrow in Debug formatting.
rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs	Remove redundant borrow in panic formatting.
rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs	Remove redundant borrows in internal error formatting.
rs/consensus/dkg/src/remote.rs	Remove redundant borrow in error formatting.
rs/config/src/crypto.rs	Remove redundant borrow in permissions error formatting.
rs/canister_sandbox/src/rpc.rs	Simplify map iteration using values().
rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs	Simplify Option logic using filter for non-zero resource limit.
rs/canister_client/src/http_client.rs	Remove redundant borrow in response formatting.
rs/canister_client/src/cbor.rs	Remove redundant borrow in error formatting.
rs/boundary_node/ic_boundary/src/rate_limiting/generic.rs	Simplify rule evaluation using ? and if let chains.
rs/bitcoin/ckbtc/minter/src/tx.rs	Remove redundant borrow in Display formatting.
rs/bitcoin/ckbtc/minter/src/state/eventlog.rs	Remove redundant borrow in error formatting.
rs/bitcoin/ckbtc/minter/src/state.rs	Simplify Option logic via filter; remove redundant borrow in panic formatting.
Cargo.toml	Bump ethnum dependency version.
Cargo.lock	Refresh locked dependency versions/checksums for the upgrade.
Cargo.Bazel.toml.lock	Refresh Bazel cargo lock metadata (e.g., ethnum, windows-sys, socket2).
Cargo.Bazel.json.lock	Refresh Bazel JSON lock metadata/checksum and crate versions.
bazel/rust.MODULE.bazel	Update Bazel crate spec for ethnum to match Cargo.toml.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

1. Update unreleased_changelog.md (if there are behavior changes, even if they are
   non-breaking).

2. Are there BREAKING changes?

3. Is a data migration needed?

4. Security review?

How to Satisfy This Automatic Review

1. Go to the bottom of the pull request page.

2. Look for where it says this bot is requesting changes.

3. Click the three dots to the right.

4. Select "Dismiss review".

5. In the text entry box, respond to each of the numbered items in the previous
   section, declare one of the following:

• Done.

• $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
  canister behavior changes.", or for item 2, "Existing APIs
  behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/f975f1a5-0a47-4a3b-b7f0-a55609e90390?scanId=91bf512c-7b65-41c3-8d13-d78f1d4f9a59&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Bug Fix	► rs/canister_sandbox/src/rpc.rs     Replace iter on mut_repr.cells.iter() with iter over values() in flush_with_errors to handle cells correctly
Bug Fix	► rs/execution_environment/src/execution_environment.rs     Format strings without extraneous reference in CanisterNotFound errors
Bug Fix	► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs     Remove unnecessary reference in assertion messages and values in several places
Bug Fix	► rs/nns/governance/src/neuron_data_validation.rs     Use known_neuron_data()? to safely access name
Bug Fix	► rs/prep/src/internet_computer.rs     Iterate over subnets and membership through values() to simplify access
Bug Fix	► rs/registry/admin/bin/main.rs     Remove unnecessary reference when formatting strings for WASM module hashes and print statements
Bug Fix	► rs/registry/canister/src/invariants/endpoint.rs     Access endpoint fields directly instead of references in error message
Bug Fix	► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs     Use inline formatting for LOG_PREFIX and payload in log statements; simplify dc.id formatting
Bug Fix	► rs/replay/src/player.rs     Remove reference in ingress id and bytes formatting for logs
Bug Fix	► rs/state_layout/src/state_layout.rs     Remove redundant & when formatting checkpoint and backup names, use direct values
Bug Fix	► rs/state_manager/src/state_sync/types.rs     Simplify StateSyncChunk FileGroup handling by using get() and iterating over indices directly
Bug Fix	► rs/test_utilities/execution_environment/src/lib.rs     Iterate over paused_subnet_messages via values_mut()
Bug Fix	► rs/interfaces/src/execution_environment/errors.rs     Use self rather than &self in error message construction
Refactor	► Cargo.toml     Update ethnum dependency version from 1.3.2 to 1.5.3 and related references in lock files and bazel module
Refactor	► Cargo.lock, Cargo.Bazel.json.lock, Cargo.Bazel.toml.lock, bazel/rust.MODULE.bazel     Update dependencies versions and checksums for ethnum, socket2, and windows-sys across multiple crates
Enhancement	► rs/canister_client/src/http_client.rs     Adjust string formatting for parsed_body when is_update_call is false
Enhancement	► rs/consensus/dkg/src/remote.rs     Format error message without unnecessary reference to dkg_tag
Enhancement	► rs/crypto/sha2/src/context/mod.rs     Format domain string without reference in Debug implementation
Enhancement	► rs/nns/governance/src/governance.rs     Fix debug formatting to avoid borrowing issue in SettleNeuronsFundParticipationRequest
Enhancement	► rs/nns/test_utils/src/gtc_helpers.rs     Print seed by value instead of by reference
Enhancement	► rs/registry/nns_data_provider/src/registry.rs     Format error string by value for agent in registry_get_value_since error
Enhancement	► rs/rosetta-api/common/rosetta_core/src/identifiers.rs     Use value.address directly in error context instead of &value.address
Enhancement	► rs/rls other areas (multiple files per diff)

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/f5e9d2bb-29a4-4b64-902a-391d65fd8b2d?scanId=491a43c0-faba-4672-9b42-48d23f615455&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Bug Fix	► rs/canister_sandbox/src/rpc.rs     Replace iter on mut_repr.cells.iter() with iter over values() in flush_with_errors to handle cells correctly
Bug Fix	► rs/execution_environment/src/execution_environment.rs     Format strings without extraneous reference in CanisterNotFound errors
Bug Fix	► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs     Remove unnecessary reference in assertion messages and values in several places
Bug Fix	► rs/nns/governance/src/neuron_data_validation.rs     Use known_neuron_data()? to safely access name
Bug Fix	► rs/prep/src/internet_computer.rs     Iterate over subnets and membership through values() to simplify access
Bug Fix	► rs/registry/admin/bin/main.rs     Remove unnecessary reference when formatting strings for WASM module hashes and print statements
Bug Fix	► rs/registry/canister/src/invariants/endpoint.rs     Access endpoint fields directly instead of references in error message
Bug Fix	► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs     Use inline formatting for LOG_PREFIX and payload in log statements; simplify dc.id formatting
Bug Fix	► rs/replay/src/player.rs     Remove reference in ingress id and bytes formatting for logs
Bug Fix	► rs/state_layout/src/state_layout.rs     Remove redundant & when formatting checkpoint and backup names, use direct values
Bug Fix	► rs/state_manager/src/state_sync/types.rs     Simplify StateSyncChunk FileGroup handling by using get() and iterating over indices directly
Bug Fix	► rs/test_utilities/execution_environment/src/lib.rs     Iterate over paused_subnet_messages via values_mut()
Bug Fix	► rs/interfaces/src/execution_environment/errors.rs     Use self rather than &self in error message construction
Refactor	► Cargo.toml     Update ethnum dependency version from 1.3.2 to 1.5.3 and related references in lock files and bazel module
Refactor	► Cargo.lock, Cargo.Bazel.json.lock, Cargo.Bazel.toml.lock, bazel/rust.MODULE.bazel     Update dependencies versions and checksums for ethnum, socket2, and windows-sys across multiple crates
Enhancement	► rs/canister_client/src/http_client.rs     Adjust string formatting for parsed_body when is_update_call is false
Enhancement	► rs/consensus/dkg/src/remote.rs     Format error message without unnecessary reference to dkg_tag
Enhancement	► rs/crypto/sha2/src/context/mod.rs     Format domain string without reference in Debug implementation
Enhancement	► rs/nns/governance/src/governance.rs     Fix debug formatting to avoid borrowing issue in SettleNeuronsFundParticipationRequest
Enhancement	► rs/nns/test_utils/src/gtc_helpers.rs     Print seed by value instead of by reference
Enhancement	► rs/registry/nns_data_provider/src/registry.rs     Format error string by value for agent in registry_get_value_since error
Enhancement	► rs/rosetta-api/common/rosetta_core/src/identifiers.rs     Use value.address directly in error context instead of &value.address
Enhancement	► rs/rls other areas (multiple files per diff)

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/bd30fac0-c6f5-4bec-83e2-480d2b345946?scanId=d0343abc-55a5-4a56-88aa-d2ead955664e&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Refactor	► rs/consensus/dkg/src/remote.rs      Use direct variable in error message formatting (remove &).
Refactor	► rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs      Use non-reference in string formatting for oldest_public_key.
Refactor	► rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs      Remove & in self.listener.local_addr() usage.
Refactor	► rs/crypto/sha2/src/context/mod.rs      Use owned value self.domain in Debug implementation.
Refactor	► rs/execution_environment/src/canister_manager/types.rs      Remove unnecessary reference in CanisterNotFound message.
Refactor	► rs/execution_environment/src/execution_environment.rs      Remove reference in CanisterNotFound error message constructions.
Refactor	► rs/execution_environment/src/scheduler.rs      Replace conditional map/and_then with filter to skip zero delta.
Refactor	► rs/ic_os/build_tools/dflate/src/main.rs      Use file.display() consistently in error message.
Refactor	► rs/ic_os/networking/network/src/interfaces.rs      Inline formatting of ip when printing.
Refactor	► rs/ic_os/networking/network/src/systemd.rs      Format ipv6_address inline; adjust formatting in error message.
Refactor	► rs/interfaces/src/execution_environment/errors.rs      Format strings using self instead of &self in error descriptions.
Refactor	► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs       Dereference in assertions to use owned values.
Refactor	► rs/replica/bin/replica/main.rs      Use owned value in debug prints.
Refactor	► rs/replay/src/backup.rs      Use owned artifact_path in log.
Refactor	► rs/replay/src/player.rs      Use owned values in debug print for ingress id.
Refactor	► rs/sns/cli/src/deploy.rs      Use owned values in several println! outputs.
Refactor	► rs/sns/governance/src/extensions.rs      Format trait object via operation_type without reference.
Refactor	► rs/sns/governance/src/icrc_ledger_helper.rs      Use value instead of reference in Nat decoding error message.
Refactor	► rs/sns/governance/src/proposal.rs      Use owned motion_text/current parameters in formatting.
Refactor	► rs/state_layout/src/state_layout.rs      Use owned checkpoint_name in path construction.
Refactor	► rs/state_manager/src/state_sync/types.rs      Use ? operator to unwrap chunk_table_indices instead of conditional.
Refactor	► rs/test_utilities/execution_environment/src/lib.rs      Use values_mut() for paused_subnet_messages iteration.
Refactor	► rs/tests/boundary_nodes/integration_test_common/src/lib.rs      Formatting unchanged (commented as placeholder).

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/6992424c-495e-4621-b441-efd6821a4be6?scanId=9e07bb37-9996-4a36-81ff-bd0f3f4db4d9&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Refactor	► rs/consensus/dkg/src/remote.rs      Use direct variable in error message formatting (remove &).
Refactor	► rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs      Use non-reference in string formatting for oldest_public_key.
Refactor	► rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs      Remove & in self.listener.local_addr() usage.
Refactor	► rs/crypto/sha2/src/context/mod.rs      Use owned value self.domain in Debug implementation.
Refactor	► rs/execution_environment/src/canister_manager/types.rs      Remove unnecessary reference in CanisterNotFound message.
Refactor	► rs/execution_environment/src/execution_environment.rs      Remove reference in CanisterNotFound error message constructions.
Refactor	► rs/execution_environment/src/scheduler.rs      Replace conditional map/and_then with filter to skip zero delta.
Refactor	► rs/ic_os/build_tools/dflate/src/main.rs      Use file.display() consistently in error message.
Refactor	► rs/ic_os/networking/network/src/interfaces.rs      Inline formatting of ip when printing.
Refactor	► rs/ic_os/networking/network/src/systemd.rs      Format ipv6_address inline; adjust formatting in error message.
Refactor	► rs/interfaces/src/execution_environment/errors.rs      Format strings using self instead of &self in error descriptions.
Refactor	► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs       Dereference in assertions to use owned values.
Refactor	► rs/replica/bin/replica/main.rs      Use owned value in debug prints.
Refactor	► rs/replay/src/backup.rs      Use owned artifact_path in log.
Refactor	► rs/replay/src/player.rs      Use owned values in debug print for ingress id.
Refactor	► rs/sns/cli/src/deploy.rs      Use owned values in several println! outputs.
Refactor	► rs/sns/governance/src/extensions.rs      Format trait object via operation_type without reference.
Refactor	► rs/sns/governance/src/icrc_ledger_helper.rs      Use value instead of reference in Nat decoding error message.
Refactor	► rs/sns/governance/src/proposal.rs      Use owned motion_text/current parameters in formatting.
Refactor	► rs/state_layout/src/state_layout.rs      Use owned checkpoint_name in path construction.
Refactor	► rs/state_manager/src/state_sync/types.rs      Use ? operator to unwrap chunk_table_indices instead of conditional.
Refactor	► rs/test_utilities/execution_environment/src/lib.rs      Use values_mut() for paused_subnet_messages iteration.
Refactor	► rs/tests/boundary_nodes/integration_test_common/src/lib.rs      Formatting unchanged (commented as placeholder).

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/14c3f6d7-8c8e-4a33-9b18-2f289f25b557?scanId=c6b56beb-103f-47fc-91be-62e7e9027826&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type

Relevant files

Bug Fix

► rs/consensus/dkg/src/remote.rs       Fix formatting in error message for dkg tag ► rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs       Correct formatting of oldest_public_key in error messages ► rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs       Remove unnecessary reference in error context ► rs/canister_client/src/cbor.rs       Use value directly in error message ► rs/canister_client/src/http_client.rs       Use value when formatting parsed_body in readable_response ► rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs       Replace and_then with filter for non-zero delta ► rs/interfaces/src/execution_environment/errors.rs       Format error string without borrowing for canister_id in several places ► rs/nns/governance/src/governance.rs       Use moved request in debug formatting ► rs/replay/src/player.rs       Use moved ingress id in log output ► rs/registry/admin/bin/main.rs       Use moved value in various string interpolations ► rs/registry/canister/src/invariants/endpoint.rs       Use value directly in error message construction ► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs       Inline payload printing to avoid borrowing in log statements ► rs/registry/nns_data_provider/src/registry.rs       Use moved agent in error message construction ► rs/replay/src/backup.rs       Use moved artifact_path in log statement ► rs/replay/src/player.rs       Use moved msg.ingress.id() in log output ► rs/rosetta-api/common/rosetta_core/src/identifiers.rs       Use moved value.address in error formatting ► rs/rosetta-api/icp/src/request_handler.rs       Use moved address in error formatting ► rs/sns/governance/src/extensions.rs       Use moved operation_type in name formatting ► rs/sns/governance/src/icrc_ledger_helper.rs       Use moved value in error message construction ► rs/sns/governance/src/proposal.rs       Use moved motion_text/new_parameters in string interpolation ► rs/state_layout/src/state_layout.rs       Use moved checkpoint_name in path construction ► rs/state_manager/src/state_sync/types.rs       Use moved index in loop over chunk tables ► rs/test_utilities/execution_environment/src/lib.rs       Use moved paused_subnet_message reference in loop ► rs/registry/canister/src/invariants/endpoint.rs       Use endpoint.ip_addr/endpoint.port directly in message ► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs       Use moved payload in log and error messages ► rs/prep/src/internet_computer.rs       Iterate over subnets/membership by value references ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/sns/cli/src/deploy.rs       Use moved sns_canister_ids and output formatting ► rs/sns/governance/src/extensions.rs       Use moved operation_type in name() formatting ► rs/embedders/src/wasm_utils/validation.rs       Use moved module.types.types value in error message ► rs/consensus/dkg/src/remote.rs       Format string using dkg_tag directly ► rs/crypto/sha2/src/context/mod.rs       Use moved domain string in Debug implementation ► rs/ic_os/networking/network/src/interfaces.rs       Format ip address inline in log statement ► rs/ic_os/networking/network/src/systemd.rs       Format interface name and connectivity error with inline values ► rs/execution_environment/src/canister_manager/types.rs       Use moved canister_id in error message formatting ► rs/execution_environment/src/execution_environment.rs       Use moved canister_id in error message formatting ► rs/execution_environment/src/scheduler.rs       Use filter to replace and_then for non-zero delta ► rs/ic_os/build_tools/dflate/src/main.rs       Use moved file display value in error message ► rs/consensus/dkg/src/remote.rs       Format string with dkg_id.dkg_tag without borrow ► rs/ethereum/cketh/minter/src/map.rs       Iterate keys() instead of by_key.iter() to collect removals ► rs/embedders/src/wasm_utils/validation.rs       Use moved payload in log statements ► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs       Use moved from/spender in assert messages ► rs/nns/governance/src/neuron_data_validation.rs       Use known_neuron_data()? to access name ► rs/nns/test_utils/src/gtc_helpers.rs       Use moved seed in println ► rs/orchestrator/src/catch_up_package_provider.rs       Use moved cup_file_path in error format ► rs/prep/src/internet_computer.rs       Use moved node_operator_principal_id in iteration ► rs/replay/src/player.rs       Use moved ingress id() in log output ► rs/rosetta-api/icp/src/request_handler.rs       Use moved address in error formatting ► rs/rust_canisters/canister_test/src/canister.rs       Use moved error strings in logs ► rs/registry/admin/bin/main.rs       Use moved canister_id and wasm_module_sha256 in titles ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/registry/nns_data_provider/src/registry.rs       Use moved agent in error message ► rs/rs/sns/governance/src/icrc_ledger_helper.rs       Use moved value in Nat decode error

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 58eab26.

Security Overview

• 🔎 Scanned files: 63 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/783a9bd4-fb4e-4e10-ab3c-c2fb2ddfb92f?scanId=09c0f76b-c64f-4dda-8a5d-f30f14083a27&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type

Relevant files

Bug Fix

► rs/consensus/dkg/src/remote.rs       Fix formatting in error message for dkg tag ► rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs       Correct formatting of oldest_public_key in error messages ► rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs       Remove unnecessary reference in error context ► rs/canister_client/src/cbor.rs       Use value directly in error message ► rs/canister_client/src/http_client.rs       Use value when formatting parsed_body in readable_response ► rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs       Replace and_then with filter for non-zero delta ► rs/interfaces/src/execution_environment/errors.rs       Format error string without borrowing for canister_id in several places ► rs/nns/governance/src/governance.rs       Use moved request in debug formatting ► rs/replay/src/player.rs       Use moved ingress id in log output ► rs/registry/admin/bin/main.rs       Use moved value in various string interpolations ► rs/registry/canister/src/invariants/endpoint.rs       Use value directly in error message construction ► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs       Inline payload printing to avoid borrowing in log statements ► rs/registry/nns_data_provider/src/registry.rs       Use moved agent in error message construction ► rs/replay/src/backup.rs       Use moved artifact_path in log statement ► rs/replay/src/player.rs       Use moved msg.ingress.id() in log output ► rs/rosetta-api/common/rosetta_core/src/identifiers.rs       Use moved value.address in error formatting ► rs/rosetta-api/icp/src/request_handler.rs       Use moved address in error formatting ► rs/sns/governance/src/extensions.rs       Use moved operation_type in name formatting ► rs/sns/governance/src/icrc_ledger_helper.rs       Use moved value in error message construction ► rs/sns/governance/src/proposal.rs       Use moved motion_text/new_parameters in string interpolation ► rs/state_layout/src/state_layout.rs       Use moved checkpoint_name in path construction ► rs/state_manager/src/state_sync/types.rs       Use moved index in loop over chunk tables ► rs/test_utilities/execution_environment/src/lib.rs       Use moved paused_subnet_message reference in loop ► rs/registry/canister/src/invariants/endpoint.rs       Use endpoint.ip_addr/endpoint.port directly in message ► rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs       Use moved payload in log and error messages ► rs/prep/src/internet_computer.rs       Iterate over subnets/membership by value references ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/sns/cli/src/deploy.rs       Use moved sns_canister_ids and output formatting ► rs/sns/governance/src/extensions.rs       Use moved operation_type in name() formatting ► rs/embedders/src/wasm_utils/validation.rs       Use moved module.types.types value in error message ► rs/consensus/dkg/src/remote.rs       Format string using dkg_tag directly ► rs/crypto/sha2/src/context/mod.rs       Use moved domain string in Debug implementation ► rs/ic_os/networking/network/src/interfaces.rs       Format ip address inline in log statement ► rs/ic_os/networking/network/src/systemd.rs       Format interface name and connectivity error with inline values ► rs/execution_environment/src/canister_manager/types.rs       Use moved canister_id in error message formatting ► rs/execution_environment/src/execution_environment.rs       Use moved canister_id in error message formatting ► rs/execution_environment/src/scheduler.rs       Use filter to replace and_then for non-zero delta ► rs/ic_os/build_tools/dflate/src/main.rs       Use moved file display value in error message ► rs/consensus/dkg/src/remote.rs       Format string with dkg_id.dkg_tag without borrow ► rs/ethereum/cketh/minter/src/map.rs       Iterate keys() instead of by_key.iter() to collect removals ► rs/embedders/src/wasm_utils/validation.rs       Use moved payload in log statements ► rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs       Use moved from/spender in assert messages ► rs/nns/governance/src/neuron_data_validation.rs       Use known_neuron_data()? to access name ► rs/nns/test_utils/src/gtc_helpers.rs       Use moved seed in println ► rs/orchestrator/src/catch_up_package_provider.rs       Use moved cup_file_path in error format ► rs/prep/src/internet_computer.rs       Use moved node_operator_principal_id in iteration ► rs/replay/src/player.rs       Use moved ingress id() in log output ► rs/rosetta-api/icp/src/request_handler.rs       Use moved address in error formatting ► rs/rust_canisters/canister_test/src/canister.rs       Use moved error strings in logs ► rs/registry/admin/bin/main.rs       Use moved canister_id and wasm_module_sha256 in titles ► rs/registry/admin/bin/main.rs       Use moved wasm_module_sha256 in formatting ► rs/registry/nns_data_provider/src/registry.rs       Use moved agent in error message ► rs/rs/sns/governance/src/icrc_ledger_helper.rs       Use moved value in Nat decode error

No canister behavioural changes. Just small refactors.