fix: return all transactions when start is None in index get_account_…#10733
Draft
Rachit2323 wants to merge 3 commits into
Draft
fix: return all transactions when start is None in index get_account_…#10733Rachit2323 wants to merge 3 commits into
Rachit2323 wants to merge 3 commits into
Conversation
Contributor
basvandijk
reviewed
Jul 10, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Calling
get_account_transactionswithout astartvalue always returns empty results, even when the account has transactions.Why
The code was using
u64::MAXas a default forstart. Then it filtered for blocks less thanu64::MAX— but since the search started atu64::MAX, nothing was ever returned.Fix
When
startis not given, return all transactions instead of filtering.Changes
rs/ledger_suite/icrc1/index-ng/src/main.rsrs/ledger_suite/icp/index/src/main.rs