Skip to content

fix(governance): Correct DeleteSubnet proposal description #10742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mraszyk merged 4 commits into from
Jul 13, 2026
+17 −11
Merged

fix(governance): Correct DeleteSubnet proposal description #10742

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45668a8
fix(nns): Correct DeleteSubnet proposal description
mraszyk Jul 13, 2026
177986d
docs(nns): Add changelog entry for DeleteSubnet description fix
mraszyk Jul 13, 2026
cf4a082
docs(nns): Note that system subnets cannot be deleted in DeleteSubnet…
mraszyk Jul 13, 2026
f8b5542
docs(nns): Update changelog for system subnet DeleteSubnet note
mraszyk Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rs/nns/governance/api/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4283,9 +4283,8 @@ pub enum NnsFunction {
/// The proposal requests to split a subnet.
SplitSubnet = 56,
/// Delete a subnet. The subnet record, catch-up package, threshold signing key
/// and routing table entries are removed from the registry, and the subnet's
/// nodes become unassigned.
/// Currently limited to CloudEngine subnets.
/// and routing table entries are removed from the registry, the subnet is
/// removed from the subnet list, and the subnet's nodes become unassigned.
Comment thread
mraszyk marked this conversation as resolved.
DeleteSubnet = 57,
/// Set or unset the default subnet to which `SetupInitialDKG` management
/// canister calls are routed when no subnet is specified explicitly. If unset,
Expand Down
5 changes: 2 additions & 3 deletions rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,8 @@ enum NnsFunction {
NNS_FUNCTION_SPLIT_SUBNET = 56;

// Delete a subnet. The subnet record, catch-up package, threshold signing key
// and routing table entries are removed from the registry, and the subnet's
// nodes become unassigned.
// Currently limited to CloudEngine subnets.
// and routing table entries are removed from the registry, the subnet is
// removed from the subnet list, and the subnet's nodes become unassigned.
NNS_FUNCTION_DELETE_SUBNET = 57;

// Set or unset the default subnet to which `SetupInitialDKG` management
Expand Down
5 changes: 2 additions & 3 deletions rs/nns/governance/src/gen/ic_nns_governance.pb.v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5277,9 +5277,8 @@ pub enum NnsFunction {
/// The proposal requests to split a subnet.
SplitSubnet = 56,
/// Delete a subnet. The subnet record, catch-up package, threshold signing key
/// and routing table entries are removed from the registry, and the subnet's
/// nodes become unassigned.
/// Currently limited to CloudEngine subnets.
/// and routing table entries are removed from the registry, the subnet is
/// removed from the subnet list, and the subnet's nodes become unassigned.
DeleteSubnet = 57,
/// Set or unset the default subnet to which `SetupInitialDKG` management
/// canister calls are routed when no subnet is specified explicitly. If unset,
Expand Down
4 changes: 2 additions & 2 deletions rs/nns/governance/src/proposals/execute_nns_function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,8 +935,8 @@ impl ValidNnsFunction {
}
ValidNnsFunction::DeleteSubnet => {
"Delete a subnet. The subnet record, catch-up package, threshold signing key \
and routing table entries are removed from the registry, and the subnet's \
nodes become unassigned. Currently limited to CloudEngine subnets."
and routing table entries are removed from the registry, the subnet is \
removed from the subnet list, and the subnet's nodes become unassigned."
}
ValidNnsFunction::SetDefaultInitialDkgSubnet => {
"Set or unset the default subnet to which `SetupInitialDKG` management canister \
Expand Down
4 changes: 4 additions & 0 deletions rs/nns/governance/unreleased_changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,8 @@ on the process that this file is part of, see

## Fixed

* Corrected the `DeleteSubnet` proposal description: dropped the outdated
"Currently limited to CloudEngine subnets" clause and added that the subnet
is also removed from the subnet list.

## Security
Loading