feat: Further limit message memory on small nodes#10757
Conversation
This PR addresses an issue when running a subnet with nodes that have limited RAM. The message memory, i.e. the storage required by messages in queues, used to be bound only by a constant of 20 GB. This is however not safe as they are currently kept fully in RAM, and some newer nano nodes will have as little as 8 GB of RAM. Those subnets however already limit the heap delta using a parameter in the registry, as the heap delta is also stored in RAM. This commit simply reuses the heap delta limit to also give an upper bound on the message memory. Both bounded and unbounded wait messages are now limited to min(heap_delta/3, old_constant). On large nodes, this commit makes no difference at all. Most code changes are due to the fact that message memory is no longer a fixed value that can be set at replica startup, and accompanying necessary changes to the test framework.
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to 2af38e7. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 2af38e7. Security Overview
Detected Code Changes
|
daniel-wong-dfinity-org-twin
left a comment
There was a problem hiding this comment.
Approving tiny change in Governance-owned code.
This PR addresses an issue when running a subnet with nodes that have limited RAM. The message memory, i.e. the storage required by messages in queues, used to be bound only by a constant of 20 GB. This is however not safe as they are currently kept fully in RAM, and some newer nano nodes will have as little as 8 GB of RAM.
Those subnets however already limit the heap delta using a parameter in the registry, as the heap delta is also stored in RAM. This commit simply reuses the heap delta limit to also give an upper bound on the message memory. Both bounded and unbounded wait messages are now limited to min(heap_delta/3, old_constant). On large nodes, this commit makes no difference at all.
Most code changes are due to the fact that message memory is no longer a fixed value that can be set at replica startup, and accompanying necessary changes to the test framework.