chore: rustc: 1.95.0 -> 1.97.0#10762
Conversation
This PR bumps the Rust version to v1.95.0.
## Canbench summary
===================================================================================
## ckBTC minter
target: //rs/bitcoin/ckbtc/minter:ckbtc_minter_canbench
results file: rs/bitcoin/ckbtc/minter/canbench/results.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 7 | regressed 0 | improved 7 | new 0 | unchanged 0]
change: [max -163.50K | p75 -163.64K | median -163.68K | p25 -163.68K |
min -164.78K]
change %: [max -38.39% | p75 -38.72% | median -38.78% | p25 -38.81% |
min -38.99%]
heap_increase:
status: No significant changes 👍
counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|------------------------------------------------------------------------------------|-------|---------|---------|----|--------|-----|---------|
| - |
build_estimate_retrieve_btc_fee_1_50k_sats::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_1_50k_sats::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_2_100k_sats::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_3_1m_sats::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_4_10m_sats::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_5_1_btc::build_unsigned_transaction_from_inputs
| 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% |
| - |
build_unsigned_transaction_6_10_btc::build_unsigned_transaction_from_inputs
| 1 | 3.70K | -3.50% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_3_1m_sats::greedy | 1 | 3.06K | -13.00%
| 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_2_100k_sats::greedy | 1 | 4.43K |
-13.30% | 0 | 0.00% | 0 | 0.00% |
| - | build_estimate_retrieve_btc_fee_1_50k_sats::greedy | 1 | 4.38K |
-13.42% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_1_50k_sats::greedy | 1 | 4.38K |
-13.42% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_4_10m_sats::greedy | 1 | 4.08K |
-14.15% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_5_1_btc::greedy | 1 | 4.08K | -14.15% |
0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_6_10_btc::greedy | 1 | 11.85K | -14.40%
| 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_6_10_btc | | 264.48K | -38.39% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_6_10_btc::build_unsigned_transaction |
1 | 261.93K | -38.61% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_4_10m_sats | | 259.10K | -38.72% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_5_1_btc | | 259.10K | -38.72% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_3_1m_sats | | 258.14K | -38.78% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_2_100k_sats | | 258.06K | -38.81% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_1_50k_sats | | 258.02K | -38.81% | 0 |
0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_4_10m_sats::build_unsigned_transaction
| 1 | 256.56K | -38.94% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_5_1_btc::build_unsigned_transaction | 1
| 256.56K | -38.94% | 0 | 0.00% | 0 | 0.00% |
| - | build_estimate_retrieve_btc_fee_1_50k_sats | | 255.97K | -38.99% |
0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_3_1m_sats::build_unsigned_transaction |
1 | 255.59K | -39.01% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_2_100k_sats::build_unsigned_transaction
| 1 | 255.52K | -39.04% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_1_50k_sats::build_unsigned_transaction
| 1 | 255.47K | -39.04% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_6_10_btc::utxos_selection | 1 | 256.06K
| -39.12% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_4_10m_sats::utxos_selection | 1 |
251.12K | -39.43% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_5_1_btc::utxos_selection | 1 | 251.12K
| -39.43% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_3_1m_sats::utxos_selection | 1 |
250.16K | -39.50% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_2_100k_sats::utxos_selection | 1 |
250.08K | -39.53% | 0 | 0.00% | 0 | 0.00% |
| - | build_estimate_retrieve_btc_fee_1_50k_sats::utxos_selection | 1 |
250.03K | -39.53% | 0 | 0.00% | 0 | 0.00% |
| - | build_unsigned_transaction_1_50k_sats::utxos_selection | 1 |
250.03K | -39.53% | 0 | 0.00% | 0 | 0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## ckETH minter
target: //rs/ethereum/cketh/minter:cketh_minter_canbench
results file: rs/ethereum/cketh/minter/canbench/results.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0]
change: [max -108.95M | p75 -108.95M | median -108.95M | p25 -108.95M |
min -108.95M]
change %: [max -11.11% | p75 -11.11% | median -11.11% | p25 -11.11% |
min -11.11%]
heap_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|--------------------|-------|---------|---------|-----|--------|-----|---------|
| - | bench_post_upgrade | | 871.40M | -11.11% | 222 | 0.00% | 0 | 0.00%
|
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## ICP ledger
target: //rs/ledger_suite/icp/ledger:ledger_canbench
results file: rs/ledger_suite/icp/ledger/canbench_results/canbench.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0]
change: [max -308.62M | p75 -308.62M | median -308.62M | p25 -308.62M |
min -308.62M]
change %: [max -2.14% | p75 -2.14% | median -2.14% | p25 -2.14% | min
-2.14%]
heap_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|---------------------------------------|-------|--------|---------|----|--------|-----|---------|
| - | bench_endpoints | | 14.08B | -2.14% | 62 | 0.00% | 256 | 0.00% |
| - | bench_endpoints::icrc2_transfer_from | 1 | 6.65B | -2.71% | 2 |
0.00% | 128 | 0.00% |
| - | bench_endpoints::query_blocks | 1 | 36.75M | -3.49% | 13 | 0.00% |
0 | 0.00% |
| - | bench_endpoints::query_encoded_blocks | 1 | 6.91M | -6.45% | 0 |
0.00% | 0 | 0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## ICRC-1 ledger (u256)
target: //rs/ledger_suite/icrc1/ledger:canbench_u256
results file:
rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1]
change: [max -21.14K | p75 -883.02M | median -1.77B | p25 -2.65B | min
-3.53B]
change %: [max -0.24% | p75 -1.82% | median -3.39% | p25 -4.97% | min
-6.54%]
heap_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|-----------------------------------------------|-------|---------|---------|-----|--------|-----|---------|
| + | bench_icrc1_transfers::post_upgrade | 1 | 379.28M | +7.98% | 71 |
0.00% | 0 | 0.00% |
| + | bench_icrc1_transfers::upgrade | 1 | 529.25M | +5.87% | 200 |
0.00% | 128 | 0.00% |
| - | bench_icrc1_transfers::icrc1_transfer | 1 | 12.31B | -4.16% | 31 |
0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers::get_blocks | 1 | 7.39M | -5.27% | 0 | 0.00%
| 0 | 0.00% |
| - | bench_icrc1_transfers::icrc3_get_blocks | 1 | 8.50M | -5.79% | 0 |
0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers | | 50.46B | -6.54% | 262 | 0.00% | 256 |
0.00% |
| - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 19.66B | -7.40% |
3 | 0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers::icrc2_approve | 1 | 17.76B | -7.49% | 28 |
0.00% | 128 | 0.00% |
| - | bench_icrc1_transfers::icrc103_get_allowances | 1 | 5.25M |
-19.06% | 0 | 0.00% | 0 | 0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## ICRC-1 ledger (u64)
target: //rs/ledger_suite/icrc1/ledger:canbench_u64
results file:
rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1]
change: [max -20.83K | p75 -871.90M | median -1.74B | p25 -2.62B | min
-3.49B]
change %: [max -0.24% | p75 -1.84% | median -3.45% | p25 -5.05% | min
-6.65%]
heap_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|-----------------------------------------------|-------|---------|---------|-----|--------|-----|---------|
| + | bench_icrc1_transfers::post_upgrade | 1 | 379.10M | +8.02% | 73 |
0.00% | 0 | 0.00% |
| + | bench_icrc1_transfers::upgrade | 1 | 528.83M | +5.85% | 202 |
0.00% | 128 | 0.00% |
| - | bench_icrc1_transfers::icrc1_transfer | 1 | 11.77B | -4.25% | 31 |
0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers::get_blocks | 1 | 6.81M | -5.80% | 0 | 0.00%
| 0 | 0.00% |
| - | bench_icrc1_transfers::icrc3_get_blocks | 1 | 7.89M | -6.32% | 0 |
0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers | | 48.92B | -6.65% | 264 | 0.00% | 256 |
0.00% |
| - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 19.21B | -7.49% |
3 | 0.00% | 0 | 0.00% |
| - | bench_icrc1_transfers::icrc2_approve | 1 | 17.22B | -7.62% | 28 |
0.00% | 128 | 0.00% |
| - | bench_icrc1_transfers::icrc103_get_allowances | 1 | 4.42M |
-21.76% | 0 | 0.00% | 0 | 0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## NNS governance
target: //rs/nns/governance:governance-canbench
results file: rs/nns/governance/canbench/canbench_results.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 28 | regressed 0 | improved 3 | new 0 | unchanged 25]
change: [max +924.98K | p75 -852 | median -60.22K | p25 -465.20K | min
-3.14M]
change %: [max +1.62% | p75 -0.76% | median -2.24% | p25 -2.78% | min
-7.58%]
heap_increase:
status: No significant changes 👍
counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|--------------------------------------------------------|-------|--------|---------|----|--------|-----|---------|
| - | unstake_maturity_of_dissolved_neurons::list_neuron_ids | 1 |
37.65M | -5.56% | 0 | 0.00% | 0 | 0.00% |
| - | list_ready_to_spawn_neuron_ids | | 36.31M | -5.59% | 0 | 0.00% | 0
| 0.00% |
| - | compute_ballots_for_new_proposal_with_stable_neurons | | 2.30M |
-6.16% | 0 | 0.00% | 256 | 0.00% |
| - | neuron_metrics_calculation | | 3.35M | -7.58% | 0 | 0.00% | 0 |
0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
===================================================================================
## Registry canister
target: //rs/registry/canister:registry-canbench
results file: rs/registry/canister/canbench/canbench_results.yml
===================================================================================
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 14 | regressed 0 | improved 10 | new 0 | unchanged 4]
change: [max -5 | p75 -1.15M | median -10.78M | p25 -32.86M | min
-1.30B]
change %: [max -0.00% | p75 -0.63% | median -3.09% | p25 -9.71% | min
-13.80%]
heap_increase:
status: No significant changes 👍
counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
---------------------------------------------------
Only significant changes:
| status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% |
|--------|-------------------------------------------------------------|-------|---------|---------|-----|--------|-----|---------|
| - | get_subnet_for_canister_100_times_10k | | 685.74M | -2.43% | 0 |
0.00% | 0 | 0.00% |
| - | upgrade_with_routing_table_10k | | 5.46B | -2.98% | 342 | 0.00% |
0 | 0.00% |
| - | upgrade_with_routing_table_10k::post_upgrade | 1 | 5.43B | -2.99%
| 217 | 0.00% | 0 | 0.00% |
| - | upgrade_with_routing_table_1k | | 669.20M | -3.02% | 40 | 0.00% |
0 | 0.00% |
| - | upgrade_with_routing_table_1k::post_upgrade | 1 | 666.33M | -3.04%
| 25 | 0.00% | 0 | 0.00% |
| - | upgrade_with_routing_table_100 | | 184.18M | -3.16% | 7 | 0.00% |
0 | 0.00% |
| - | upgrade_with_routing_table_100::post_upgrade | 1 | 183.30M |
-3.17% | 4 | 0.00% | 0 | 0.00% |
| - | get_subnet_for_canister_100_times_1k | | 87.92M | -4.23% | 0 |
0.00% | 0 | 0.00% |
| - | get_subnet_for_canister_100_times_100 | | 28.45M | -8.38% | 0 |
0.00% | 0 | 0.00% |
| - | migrate_canisters_10_times_100 | | 137.68M | -10.15% | 0 | 0.00% |
0 | 0.00% |
| - | migrate_canisters_10_times_1k | | 902.16M | -11.78% | 3 | 0.00% |
0 | 0.00% |
| - | migrate_canisters_10_times_10k | | 8.98B | -12.68% | 0 | 0.00% | 0
| 0.00% |
| - | measure_routing_table_invariant_checks_shards_and_unsharded | |
230.35M | -13.80% | 138 | 0.00% | 0 | 0.00% |
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ%
= percent change
---------
Co-authored-by: IDX GitHub Automation <>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…c 1.95.0 The rustc 1.95.0 bump produces slightly larger wasm binaries and shifts deterministic execution estimates. Bump the compressed wasm size limits for ic-ckbtc-minter, sns-governance, and sns-swap, and update the hard-coded post-split load estimates in the subnet_splitting integration test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve conflicts for the rustc 1.95.0 bump: - Container image references (workflows, devcontainer, TAG): keep branch values; container-autobuild will rebuild and rewrite them on push. - canbench results (ckbtc minter, registry) and subnet-splitting test estimates: keep the rustc 1.95.0 values. Post-merge fixes: - subnet_splitting integration_test: update source/destination estimates to the measured orientation on the merged tree. - registry canbench: regenerate results.yml for master's registry code changes (values within ~3%). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…be7f49b5528e73804be39740cfe5f ic-build: sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 ic-dev: sha256:60cf67322e87bd9a6ce425ec73811014f9a6280d84db6e256c1eda720790a491
Re-run all canbench suites whose results files changed on this branch, persisting fresh benchmark numbers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…27967070fea70acf17115b4be8a34 ic-build: sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b ic-dev: sha256:ef4e171fcb98170f24d4163a3a3cefff11a380a603388f467add619c45f610a4
…4e0847d7be43124022d7e6d24919d ic-build: sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 ic-dev: sha256:d80def17941e0208e13f994cce628e0e370a59f40086cb3a0a7cdadaeb382dfc
…171c7ee7ebae00c03f24d608cd688 ic-build: sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 ic-dev: sha256:eae27468101cff14340905c9b6d1fc6caebe339c7ed474d8fee6d35015c04d61
…1b7f3f51ba132ab53ded517d492da ic-build: sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e ic-dev: sha256:7f4e0bb317291ee52f3a74e7228590582222e29f7ccd6adc353678a90a8549f4
…1b7f3f51ba132ab53ded517d492da ic-build: sha256:5ec718dc9bd15612ebec01faf718d84bec2abaa361e7a56f14c93b9290944a8b ic-dev: sha256:cefbeeb45d8c9f883ea0a7b525af39b6a19143b551333e8611664968ba6c30ad
|
Run URL: https://github.com/dfinity/ic/actions/runs/29325756039 New container images with tag: |
Fix clippy lints newly enforced by rustc 1.97.0: - useless_borrows_in_formatting: drop redundant `&`/`&mut` in format!/println!/assert!/assert_eq! arguments - for_kv_map: iterate with .keys()/.values()/.values_mut() instead of .iter()/.iter_mut() with a discarded tuple element - unneeded_wildcard_pattern: drop `amount: _` covered by `..` - dead_code: remove the local CANISTER_FREEZE_BALANCE_RESERVE duplicate in nns_shielding.rs; the identical `pub const` from ic_system_test_driver::util is already glob-imported (as used by ingress_rate_limiting.rs) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…b15ecccf767ae02c9474078f2ead4 ic-build: sha256:29d6c0a8b85d004dd8ca9ac15a84aef9a2136eb8b5be2cf026b4a5f485889c6c ic-dev: sha256:fe2ade8549e391e85490babc20da80b35f690b7e7170fecf8abf693cb45c2f50
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to b2cdfbc. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
Pull request overview
This PR upgrades the repository’s pinned Rust toolchain from 1.95.0 to 1.97.0 (including the Bazel Rust toolchain pin) and refreshes stored canbench performance baselines to reflect the new compiler/toolchain behavior.
Changes:
- Bump
rust-toolchain.tomlchannel to Rust1.97.0. - Update Bazel
rules_rusttoolchain version pin to1.97.0. - Refresh canbench result YAML files for governance and ICRC-1 ledger benchmarks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updates the pinned Rust toolchain channel to 1.97.0. |
| bazel/rust.MODULE.bazel | Updates Bazel Rust toolchain versions list to 1.97.0. |
| rs/nns/governance/canbench/canbench_results.yml | Refreshes governance canbench instruction baselines after the toolchain upgrade. |
| rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml | Refreshes ICRC-1 ledger u64 canbench instruction baselines after the toolchain upgrade. |
| rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml | Refreshes ICRC-1 ledger u256 canbench instruction baselines after the toolchain upgrade. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Upgrade the rust toolchain from 1.95.0 to 1.97.0. See: https://blog.rust-lang.org/2026/07/09/Rust-1.97.0/.