Skip to content

chore: Stop populating NetworkTopology::full_topology - #11216

Open
alin-at-dfinity wants to merge 1 commit into
masterfrom
alin/stop-populating-full_topology
Open

chore: Stop populating NetworkTopology::full_topology#11216
alin-at-dfinity wants to merge 1 commit into
masterfrom
alin/stop-populating-full_topology

Conversation

@alin-at-dfinity

Copy link
Copy Markdown
Contributor

NetworkTopology::full_topology (only populated for the NNS subnet) holds the same subnets as NetworkTopology::subnets and the same routing table as NetworkTopology::routing_table. Stop populating it, so it can be dropped in a future release.

`NetworkTopology::full_topology` (only populated for the NNS subnet) holds the same subnets as `NetworkTopology::subnets` and the same routing table as `NetworkTopology::routing_table`. Stop populating it, so it can be dropped in a future release.
@alin-at-dfinity
alin-at-dfinity requested a review from a team as a code owner August 19, 2026 09:35
@github-actions github-actions Bot added the chore label Aug 19, 2026
@zeropath-ai

zeropath-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 7864311.

Security Overview
Detected Code Changes
Change Type Relevant files
Refactor ► rs/messaging/src/message_routing.rs
    Rename variable all_subnets to subnets and adjust related logic
► rs/messaging/src/message_routing.rs
    Remove full_topology construction for non-NNS paths and set None instead
Refactor ► rs/messaging/src/message_routing.rs
    Update usage of routing_table variable name from full_routing_table to routing_table
► rs/messaging/src/message_routing.rs
    Drop construction of full_topology for non-NNS subnets
Refactor ► rs/messaging/src/message_routing.rs
    Update NetworkTopology creation to pass None for full_topology
Refactor ► rs/messaging/src/message_routing/tests.rs
    Import NetworkTopologyTesting and adjust tests to reflect topology accessors behavior
► rs/messaging/src/message_routing/tests.rs
    Replace previous tests with new approach for full_topology handling across subnets
Refactor ► rs/replicated_state/src/lib.rs
    Adjust re-exports to remove FullTopology from public path in this file
Refactor ► rs/replicated_state/src/metadata_state.rs
    Expose full_topology in testing trait and implement accessor
► rs/replicated_state/src/metadata_state.rs
    Add full_topology getter to testing implementation
Refactor ► rs/replicated_state/src/metadata_state/tests.rs
    Update tests for routing topology to reflect new full_topology related behavior and recent API changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant