Skip to content

chore(dkg): remove summary's transcripts for remote subnets (2/4) #11221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pierugo-dfinity wants to merge 1 commit into from
+3 −6
Draft

chore(dkg): remove summary's transcripts for remote subnets (2/4) #11221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions rs/consensus/dkg/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,10 +995,7 @@ mod tests {
for dkg_id in summary.dkg.configs.keys() {
assert_eq!(dkg_id.target_subnet, NiDkgTargetSubnet::Local);
}
assert_eq!(
summary.dkg.transcripts_for_remote_subnets.as_ref(),
Some(&vec![])
);
assert_eq!(summary.dkg.transcripts_for_remote_subnets.as_ref(), None);
// Verify that the remote_dkg_attempts are set to `Completed`.
assert_eq!(
summary.dkg.remote_dkg_attempts.get(&target_id),
Expand Down
4 changes: 2 additions & 2 deletions rs/types/types/src/consensus/dkg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ pub struct DkgSummary {
#[serde_as(as = "Vec<(_, _)>")]
next_transcripts: BTreeMap<NiDkgTag, NiDkgTranscript>,
/// Transcripts that are computed for remote subnets.
pub transcripts_for_remote_subnets: BackwardsCompatible<Vec<RemoteTranscriptResult>, true>,
pub transcripts_for_remote_subnets: BackwardsCompatible<Vec<RemoteTranscriptResult>, false>,
/// The length of the current interval in rounds (following the start
/// block).
pub interval_length: Height,
Expand Down Expand Up @@ -301,7 +301,7 @@ impl DkgSummary {
.collect(),
current_transcripts,
next_transcripts,
transcripts_for_remote_subnets: BackwardsCompatible::new(vec![]),
transcripts_for_remote_subnets: BackwardsCompatible::empty(),
registry_version,
interval_length,
next_interval_length,
Expand Down
Loading