Skip to content

fix: enable mld listener queries, disable multicast snooping - #11246

Merged
r-birkner merged 1 commit into
masterfrom
rjb/allow-neighbor-discovery
Aug 21, 2026
Merged

fix: enable mld listener queries, disable multicast snooping#11246
r-birkner merged 1 commit into
masterfrom
rjb/allow-neighbor-discovery

Conversation

@r-birkner

Copy link
Copy Markdown
Contributor

A few SEV-enabled machines fail to upgrade, however after a reboot the upgrade all of a sudden succeeds. The guest does not respond to MLD queries (firewall blocks them) and as a consequence, the bridge in the HostOS does not flood the group and neighbor discovery messages to the guest. This prevents the upgrade VM to connect to the active VM. This only happens if there is an active MLD querier around (switch/router). We see this issue only on very few machines.

@github-actions github-actions Bot added the fix label Aug 20, 2026
@r-birkner
r-birkner marked this pull request as ready for review August 21, 2026 07:49
@r-birkner
r-birkner requested review from a team as code owners August 21, 2026 07:49
@zeropath-ai

zeropath-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 5d9f9de.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► ic-os/components/networking/nftables/hostos/nftables.template
    Add mld-listener-query to ip6 filter block
► rs/ic_os/config/tool/templates/ic.json5.template
    Add mld-listener-query to ip6 filter block (three occurrences)
Enhancement ► rs/ic_os/networking/network/src/systemd.rs
    Update Bridge STP and MulticastSnooping settings
Enhancement ► rs/orchestrator/testdata/nftables_assigned_cloud_engine.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_assigned_replica.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_boundary_node_app_subnet.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_boundary_node_system_subnet.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_unassigned_cloud_engine.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_unassigned_replica.conf.golden
    Include mld-listener-query in ip6 filter block

@zeropath-ai

zeropath-ai Bot commented Aug 21, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 5d9f9de.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► ic-os/components/networking/nftables/hostos/nftables.template
    Add mld-listener-query to ip6 filter block
► rs/ic_os/config/tool/templates/ic.json5.template
    Add mld-listener-query to ip6 filter block (three occurrences)
Enhancement ► rs/ic_os/networking/network/src/systemd.rs
    Update Bridge STP and MulticastSnooping settings
Enhancement ► rs/orchestrator/testdata/nftables_assigned_cloud_engine.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_assigned_replica.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_boundary_node_app_subnet.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_boundary_node_system_subnet.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_unassigned_cloud_engine.conf.golden
    Include mld-listener-query in ip6 filter block
► rs/orchestrator/testdata/nftables_unassigned_replica.conf.golden
    Include mld-listener-query in ip6 filter block

@r-birkner
r-birkner added this pull request to the merge queue Aug 21, 2026
Merged via the queue into master with commit 1f89cb8 Aug 21, 2026
44 of 45 checks passed
@r-birkner
r-birkner deleted the rjb/allow-neighbor-discovery branch August 21, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants