Skip to content

feat: Windows support - #267

Merged
adamspofford-dfinity merged 67 commits into
mainfrom
spofford/windows
Jan 22, 2026
Merged

feat: Windows support#267
adamspofford-dfinity merged 67 commits into
mainfrom
spofford/windows

Conversation

@adamspofford-dfinity

@adamspofford-dfinity adamspofford-dfinity commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@adamspofford-dfinity
adamspofford-dfinity force-pushed the spofford/windows branch 2 times, most recently from 8d31588 to 558ea91 Compare January 15, 2026 18:24
@adamspofford-dfinity
adamspofford-dfinity marked this pull request as ready for review January 21, 2026 02:42
@adamspofford-dfinity
adamspofford-dfinity requested a review from a team as a code owner January 21, 2026 02:42
Comment thread .github/workflows/test.yml
Comment thread crates/icp/src/context/mod.rs
Comment thread crates/icp/src/context/mod.rs Outdated
@marc0olo

Copy link
Copy Markdown
Member

@adamspofford-dfinity when resolving the conflicts in docs/guides/installation.md, we should probably switch back from latest to v0.1.0-beta.3 for using the installer unless we get the latest tag advertised before:

curl --proto '=https' --tlsv1.2 -LsSf https://github.com/dfinity/icp-cli/releases/download/v0.1.0-beta.3/icp-cli-installer.sh | sh

unfortunately I missed to check that carefully in the previous PR.

Co-authored-by: Linwei Shang <linwei.shang@dfinity.org>
Comment thread crates/icp/src/context/mod.rs Outdated
@adamspofford-dfinity
adamspofford-dfinity enabled auto-merge (squash) January 22, 2026 00:49
@adamspofford-dfinity
adamspofford-dfinity merged commit 8f32cfd into main Jan 22, 2026
72 checks passed
@adamspofford-dfinity
adamspofford-dfinity deleted the spofford/windows branch January 22, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants