feat: icp canister metadata - #269
Merged
Merged
Conversation
viviveevee
marked this pull request as ready for review
January 15, 2026 12:05
raymondk
approved these changes
Jan 15, 2026
raymondk
left a comment
raymondk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Should we consider adding --json for consistency with other commands?
raymondk
requested changes
Jan 15, 2026
raymondk
left a comment
raymondk
left a comment
Collaborator
There was a problem hiding this comment.
There are args structs that can be reused from other commands: args::CanisterCommandArgs
Collaborator
|
add json formatting: #272 |
raymondk
self-requested a review
January 16, 2026 17:18
raymondk
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested on Slack:
icp canister metadataAlso tested manually against mainnet