Skip to content

feat(alfred): add balance privacy toggle commands #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025
Merged

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented May 22, 2025

Motivation

#6866 introduced the option for users to show or hide their balance. This PR adds the same options to be controlled through Alfred.

Screen.Recording.2025-05-22.at.21.11.10.mov

NNS1-3721

Changes

  • Add hide/show options to Alfred.

Tests

  • Add checks for signed-off and signed-on statuses.

Todos

  • Add entry to changelog (if necessary).

@yhabib yhabib force-pushed the nns1-3721/alfred branch 2 times, most recently from 2b56143 to 64b9ba7 Compare May 22, 2025 12:48
@yhabib yhabib force-pushed the nns1-3721/alfred branch from 64b9ba7 to 52be356 Compare May 22, 2025 18:31
@yhabib yhabib changed the title WIP feat(alfred): add balance privacy commands May 22, 2025
@yhabib yhabib changed the title feat(alfred): add balance privacy commands feat(alfred): add balance privacy toggle commands May 23, 2025
@yhabib yhabib marked this pull request as ready for review May 23, 2025 14:32
@yhabib yhabib requested a review from a team as a code owner May 23, 2025 14:32
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion.

@yhabib yhabib enabled auto-merge May 26, 2025 09:50
@yhabib yhabib added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit b0fac34 May 26, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3721/alfred branch May 26, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants