Skip to content

Conversation

@peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Dec 19, 2025

Motivation

AgentJS v5 was released. It was well tested (including OISY's manual testing), but we do not want to wait too long to upgrade our dependencies given the resources available (begin of next year) to potentially fix unexpected issues.

References

Changes

  • npm run update:agent

@peterpeterparker peterpeterparker requested a review from a team as a code owner December 19, 2025 08:27
@yhabib yhabib force-pushed the build/agent-js-v5 branch 2 times, most recently from b1ccc32 to 7238593 Compare December 19, 2025 14:23
@yhabib
Copy link
Contributor

yhabib commented Dec 23, 2025

Blocked by dfinity/snsdemo#561

@peterpeterparker
Copy link
Member Author

Cherry picked SNS demo upgrade provided in #7674

@peterpeterparker
Copy link
Member Author

Requires #7674

@peterpeterparker
Copy link
Member Author

I had some hiccups with npm but, seems resolved now. I have updated the lock file with the latest version of ic-js@next which I released earlier today: https://github.com/dfinity/icp-js-canisters/actions/runs/20922058794

Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick sanity check locally, and everything looks good. Thanks.

@peterpeterparker peterpeterparker added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 30a4550 Jan 13, 2026
34 checks passed
@peterpeterparker peterpeterparker deleted the build/agent-js-v5 branch January 13, 2026 06:47
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
…GuestOsVersion (#7669)

# Motivation

A new action proposal, `BlessAlternativeGuestOsVersion `, has been
added. This PR introduces support for the i18n aspect of the proposal,
allowing it to be rendered in the nns-dapp.

Relevant links:
* Bumps candid interface in
[ic-js](dfinity/icp-js-canisters#1444)
* [Candid support](#7677) for
new proposal action
* Adds support to new version of ic-js in
[nns-dapp](#7652)
* Original change in [IC](dfinity/ic#7904)

# Changes

- Add translations to for the new proposal action.

# Tests

- Not possible

# Todos

- [x] Accessibility (a11y) – any impact?
- [x] Changelog – is it needed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants