-
Notifications
You must be signed in to change notification settings - Fork 49
build(frontend): update "agentjs" @icp-sdk/core and auth to v5 #7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1ccc32 to
7238593
Compare
7238593 to
73037ca
Compare
|
Blocked by dfinity/snsdemo#561 |
|
Cherry picked SNS demo upgrade provided in #7674 |
|
Requires #7674 |
|
I had some hiccups with npm but, seems resolved now. I have updated the lock file with the latest version of ic-js@next which I released earlier today: https://github.com/dfinity/icp-js-canisters/actions/runs/20922058794 |
yhabib
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick sanity check locally, and everything looks good. Thanks.
…GuestOsVersion (#7669) # Motivation A new action proposal, `BlessAlternativeGuestOsVersion `, has been added. This PR introduces support for the i18n aspect of the proposal, allowing it to be rendered in the nns-dapp. Relevant links: * Bumps candid interface in [ic-js](dfinity/icp-js-canisters#1444) * [Candid support](#7677) for new proposal action * Adds support to new version of ic-js in [nns-dapp](#7652) * Original change in [IC](dfinity/ic#7904) # Changes - Add translations to for the new proposal action. # Tests - Not possible # Todos - [x] Accessibility (a11y) – any impact? - [x] Changelog – is it needed?
Motivation
AgentJS v5 was released. It was well tested (including OISY's manual testing), but we do not want to wait too long to upgrade our dependencies given the resources available (begin of next year) to potentially fix unexpected issues.
References
Changes
npm run update:agent