-
Notifications
You must be signed in to change notification settings - Fork 0
feat(order): add realized quote and fee onto OrderRecord #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4ce3c35
feat(order): roll up realized quote and fee onto OrderRecord
gregorydemay a86e05d
test(order): label worked-example fixture as ckBTC, note spec uses ck…
gregorydemay 17109c5
perf(state): settle fills in a single pass without an intermediate Vec
gregorydemay e71fe50
chore(canister): refresh canbench baseline for order-level scalars
gregorydemay 0efe8e5
test(canister): derive arb_order_record notional via base_scale
gregorydemay 1128a86
test(canister): make realized_scalars a literal ICP/ckUSDT example
gregorydemay 2198311
docs(candid): simplify filled_quote/filled_fee field docs
gregorydemay 6b4a9dd
refactor(state): wrap Fill in FillSettlement, single write gate, rena…
gregorydemay c730732
test(state): fold realized-scalar coverage into existing fee tests
gregorydemay e97d66c
test(int): exercise non-zero fees in partial-fill cancel test
gregorydemay 61abf99
chore(canister): refresh canbench baseline for renamed scope
gregorydemay d08b235
Merge remote-tracking branch 'origin/main' into gdemay/DEFI-2901-orde…
gregorydemay ccd8246
Merge remote-tracking branch 'origin/main' into gdemay/DEFI-2901-orde…
gregorydemay f90f243
chore(canister): refresh canbench baseline after main merge
gregorydemay df627ae
test(state): rename proptest to reflect fill_settlement + push_balanc…
gregorydemay 4abdc5c
docs(did): express order VWAP as filled_quote / filled_quantity
gregorydemay 15e624e
refactor(state): have FillSettlement own its Fill
gregorydemay 9767bfe
docs(types): align filled_quote VWAP docstring with the .did (drop ba…
gregorydemay e632896
refactor(order): promote FillSettlement to a first-class type
gregorydemay 8860030
Merge remote-tracking branch 'origin/main' into gdemay/DEFI-2901-orde…
gregorydemay b1b9d56
DEFI-2901: refactor accrue_fill
gregorydemay 20e5b7e
DEFI-2901: refactor FillSettlement
gregorydemay 67700b9
DEFI-2901: remove dead code
gregorydemay a23bf6e
DEFI-2901: simplify comments
gregorydemay 738a76e
DEFI-2901: remove unnecessary clone
gregorydemay 01ec74c
refactor(canister): encapsulate balance-op construction in a settle()…
gregorydemay 3b664d3
chore(canister): regenerate canbench results after settle() refactor
gregorydemay c2e8354
perf(canister): gate full settlement under the write gate during replay
gregorydemay c427980
test(canister): drop review-flagged comments in state tests
gregorydemay 3099210
test(canister): drop duplicate ckUSDT metadata fixture
gregorydemay c2fa150
test(canister): drive realized-scalar examples from a TestCase table
gregorydemay f676083
DEFI-2901: complete expectations
gregorydemay d1d23b4
test(canister): move record_of helper into test_fixtures
gregorydemay f0e21a0
test(canister): assert filled records via assert_eq_ignoring_timestamp
gregorydemay 933e131
test(canister): drive worked-example matching with mock_runtime_for_t…
gregorydemay 772edb2
perf(canister): gate cancel settlement under the write gate during re…
gregorydemay 3fc7aed
test(canister): build token-id fixtures via SupportedTokens::token_id
gregorydemay e28d073
test(int): drop redundant comment in cancel partial-fill refund test
gregorydemay 034d957
chore(canister): merge main, adopt collapsed place_* order builder
gregorydemay 0b2fb0b
Merge branch 'main' into gdemay/DEFI-2901-order-level-scalars
gregorydemay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.