fix: Add known extensions to telemetry #4280
Conversation
| let sanitized_value = if *id == "@extension_name" { | ||
| match matches.try_get_one::<OsString>(id) { | ||
| Ok(Some(s)) if s == "sns" || s == "nns" => { | ||
| Some(s.to_str().unwrap().to_string()) |
There was a problem hiding this comment.
Any reason why we would not just log the extension being installed always?
There was a problem hiding this comment.
Because users can define their own extensions, and we're trying to avoid inspecting user-defined strings (a pathological case, but so are extensions generally). If you want to capture Azle usage it can be manually added
There was a problem hiding this comment.
Suggestion: record the extension name from the manifest during dfx extension install, here:
https://github.com/dfinity/sdk/blob/master/src/dfx-core/src/extension/manager/install.rs#L48
There was a problem hiding this comment.
When using extension run, the extension name is available from the extension manifest here. Can we try using that rather than hardcoding a couple of known extensions?
Records when
dfx extension runis used withnnsorsns, unless it is a help command.