Skip to content

mutual dependent class not working #65 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 1.0-a6

- #65 mutual dependent class not working
- #68 CompilationException doesn't provide any information about the udnerlying problem
- #69 Expose EvalException details

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,12 @@ protected Object evalSingle(String code) {
throw new RuntimeException(e);
}

if (!event.status().isDefined())
// Undefined snippets are generally bad, unless we can still recover from them. E.g.,
// "Unresolved dependencies" errors are recoverable when those dependencies are defined in the later
// snippets.
if (event.status() != Snippet.Status.RECOVERABLE_NOT_DEFINED && !event.status().isDefined()) {
throw new CompilationException(event);
}
}
}

Expand Down