Skip to content

refactor: internalize strtobool function #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: internalize strtobool function #63

wants to merge 1 commit into from

Conversation

pismy
Copy link

@pismy pismy commented Aug 28, 2025 •
edited
Loading

Hi,

The dataclass-csv module has a hidden dependency to distutils through the use of this strtobool function... that's a bit sad for so few.

This PR internalizes the function implementation (see original), and thus also fixes the undeclared dependency to distutils.

@pismy
refactor: internalize strtobool function
5b5102e 
Allows to get rid of (hidden) dependency to distutils
dupuyarc
dupuyarc approved these changes Sep 16, 2025
View reviewed changes
Copy link

@dupuyarc dupuyarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving just for kicks, the last closed PR is from 2021, I would guess this is essentially abandoned. I'd be willing to collaborate on a supported fork if you were interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dupuyarc dupuyarc dupuyarc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pismy @dupuyarc