Cleanthat #9
Draft
Cleanthat #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cleanthat[bot]](https://avatars.githubusercontent.com/in/65550?s=60&v=4){kind=small}
Configure CleanThat
-BOX_README.md file with project information for Telegram.csproj - Updated LICENSE.md file with new lastmod date and author information - Updated README.md file with new lastmod date, project information, and version number - Updated Telegram.csproj file with changes to project references - Updated Telegram.sln file with changes to project structure and references - Added new file Directory.Build.props with project information - Added new file Directory.Build.targets with project information - Updated Telegram.Bot file with changes to subproject commit - Updated README.md file in Bot.Extensions folder with new lastmod date and project information - Updated Telegram.Bot.Extensions.csproj file with changes to target framework and package references - Updated Telegram.Bot.Extensions.sln file with changes to project structure and references - Updated BotApiToken.cs file in Bot.Extensions folder with changes to validation, parsing, and comparison methods - Updated Telegram.Constants.csproj file with changes to target framework - Added new file Telegram.Constants.props with project information - Added new file Telegram.Constants.sln with project information Please review the changes for more details.
- Updated the package references in the Telegram.Identity.csproj file. - Added a new project reference to the Bot.Extensions project. - Added a new project reference to the Constants project. FIXED: Fix incorrect project configuration in the Telegram.Identity.sln file. - Fixed the project configuration platforms in the Telegram.Identity.sln file to match the correct project configurations.
…ot.Extensions.csproj, and more
- Modified `BotApiToken.cs` to update the `Regex` method to return a `Regex` object instead of `REx`. - Modified `BotApiToken.cs` to update the `_regex` field to be of type `Regex` instead of `REx`. - Modified `BotApiToken.cs` to update the `Regex` method to return the `_regex` field instead of creating a new `REx` object. - Modified `BotApiToken.cs` to update the `IStringWithRegexValueObject<BotApiToken>.Regex` method to return the `_regex` field instead of creating a new `REx` object. - Modified `BotApiToken.cs` to update the `TryParse` method to use the `IsNullOrEmpty` method instead of `string.IsNullOrEmpty`. Here is the summary of the git diff: ```diff diff --git a/src/Bot.Extensions/Types/BotApiToken.cs b/src/Bot.Extensions/Types/BotApiToken.cs index 87e3f47..34812fa 100644 --- a/src/Bot.Extensions/Types/BotApiToken.cs +++ b/src/Bot.Extensions/Types/BotApiToken.cs @@ -66,11 +66,11 @@ public partial record struct BotApiToken : IStringWithRegexValueObject<BotApiTok #if NET7_0_OR_GREATER [GeneratedRegex(RegexString, RegexOptions.Compiled | RegexOptions.IgnoreCase)] - public static partial REx Regex(); + public static partial Regex Regex(); #else - private static readonly REx _regex = new(RegexString, Compiled | IgnoreCase); + private static readonly Regex _regex = new(RegexString, Compiled | IgnoreCase); - public static REx Regex() => _regex; + public static Regex Regex() => _regex; #endif #if NET6_0_OR_GREATER @@ -121,7 +121,7 @@ public partial record struct BotApiToken : IStringWithRegexValueObject<BotApiTok /// </summary> static string IStringWithRegexValueObject<BotApiToken>.RegexString => RegexString; #else - readonly REx IStringWithRegexValueObject<BotApiToken>.Regex() => Regex(); + readonly Regex IStringWithRegexValueObject<BotApiToken>.Regex() => Regex(); /// <summary> /// The regular expression string for validating the Bot API Token. @@ -225,7 +225,7 @@ public partial record struct BotApiToken : IStringWithRegexValueObject<BotApiTok /// Tries to parse the string representation of a Bot API Token with the specified format provider. /// </summary> public static bool TryParse(string? s, IFormatProvider? provider, out BotApiToken result) => - (result = string.IsNullOrEmpty(Validate(s).ErrorMessage) ? Parse(s) : Empty) != Empty; + (result = IsNullOrEmpty(Validate(s).ErrorMessage) ? Parse(s) : Empty) != Empty; /// <summary> /// Determines whether one Bot API Token is less than another Bot API Token. ``` Please let me know if you need any further assistance.
Dgmjr.EntityFrameworkCore.Migrations project
nb_files_neither_included_nor_excluded: 120 nb_files_formatted: 26 nb_files_already_formatted: 6 eventKey: random-f4d0856f-b6ad-431e-8657-ecfa595b6e38
Spotless configuration has changed engine=spotless nb_files_neither_included_nor_excluded: 242 nb_files_formatted: 18 nb_files_already_formatted: 33 eventKey: random-ed3f9c0b-ec68-4f50-8062-502f45a7eea6
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 9369124 | Telegram Bot Token | 12e0bbb | src/OpenIdConnect.Server/Configuration/TelegramOpenIdConnectServer.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanThat is willing to clean a protected branch.
@solven-eu/cleanthat-notify please look at me