i18n: Fix broken HTML tags and enforce dennis lint warnings in CI#4116
Merged
Conversation
and fix mistranslation of <title>
skkzsh
force-pushed
the
fix/dennis-warn-po-260501
branch
from
69e9f5c to
a505766
Compare
skkzsh
force-pushed
the
fix/dennis-warn-po-260501
branch
from
a505766 to
bec35fb
Compare
Owner
|
Very nice, thank you so much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
W303(HTML tag mismatch) rule has been excluded at the CI level sincedennis lintwas introduced in i18n: Add dennis .pot/.po lint #4097 and i18n: Enforce dennis lint warnings in CI #4105.<i>substitutions in CJK locales and an upstream false-positive regarding<title>extraction frommsgstr(False positive W303 "different html" warnings despitemsgstrcontaining identical HTML tags tomsgidmozilla/dennis#213).Problem
A blanket exclusion of
W303masks genuine HTML breakages, such as missing closing tags.In fact, broken HTML tags had been sitting unnoticed across several locales, and the CI could not catch new violations.
Changes
W303exclusion from CI to enforce the rule. 975382dW303: 8b7f261<Titel>,<Beschreibung>, 🇫🇷<titre>)</p>)<strong>opening tag) 07d334fAPI,RSS,URL,Distill.io) from thegettextscope to reduce noise. f082c8edennis-ignore: W303comments to address intentional CJK italic substitutions and the upstream<title>extraction false-positive. 6ebcd40 be7d56dAs a result,
Total number of warnings(includingW302andW303) dropped by 100+ (179 -> 76).Notes
Note
W302(Unchanged translation) remains excluded across the board in the CI.It generates too much noise due to legitimate cases where
msgstrintentionally matchesmsgid(e.g., "AI", "LLM", units, and proper nouns).