Skip to content

Conversation

@codebymikey
Copy link

The aaeba13 commit unintentionally messes up how comments are handled, because it replaces the existing HTML entirely removing the name attribute, which then leads to edits matching against the wrong index.

Steps to reproduce:

  • Attempt to book a time and expenses (/wktime/edit?startday=2025-05-19&tab=wktime&user_id=1), all on the same row
  • Click Monday, and enter a comment, then press Ok.
  • Press Monday again, and press Ok.
  • Tuesday is now suddenly flagged as having a comment, even though it doesn't.
  • Add a comment on Tuesday, and press Ok.
  • Keep opening and closing the Tuesday comment a couple more times, and you won't be able to close the modal.

@Arun-TAK
Copy link
Collaborator

Thank you for the pull request. This issue will be fixed in the next release.

@cdhana17
Copy link
Collaborator

This issue is fixed in 4.9.
4.9 is released, Please take a look.

Thanks
Dhanalakshmi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants