feat: implement option set selector in Data dimension modal (DHIS2-17872) #1746
+983
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
force-pushed
the
feat/option-set-selector-DHIS2-17872
branch
from
16d3d4a to
939b77a
Compare
edoardo
force-pushed
the
feat/option-set-selector-DHIS2-17872
branch
from
939b77a to
2ee625f
Compare
6 tasks
Some DE items other than PDE/PA can an assigned option set, but they are not supported in this feature.
edoardo
commented
Feb 21, 2025
We need to distinguish this one from the other Transfer.
Forgot the main component :)
The all items selected was rendering wrongly triggering a 2nd fetch of the same page of items which was causing duplicated items in the Transfer's source list.
…ector-DHIS2-17872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17872
Relates to dhis2/data-visualizer-app#3324
Key features
Description
The "option view mode" is enabled via the list icon added to the data items with an assigned
optionSetId.When this mode is enabled, a separate Transfer component is shown in place of the "primary" one, which is just hidden but still present in the DOM.
This allows for all selections, highlights, filtering, etc... to persist after the "option view mode" is dismissed.
Both Transfer components are affecting the same selected items list and therefore changes made in one are automatically reflected in the other.
The "option view mode" Transfer component is using filters for fetching program data element options or program attribute options depending on the clicked data item.
The source (left) part of the Transfer is only listing the options for a specific data item/type.
The selected (right) part of the Transfer has the same list as the "primary" Transfer component.
TODO
programDataElementId/programAttributeIdfilters when the backend is readyKnown issues
Screenshots
Data dimension modal:
Data dimension with option view mode modal:
