Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade app platform to v12 for Vite and React 18 #53

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

KaiVandivier
Copy link
Collaborator

@KaiVandivier KaiVandivier commented Jan 22, 2025

Based off the branch on #52; will rebase when that's merged

  • I made one small change to earthengine.js to use export default since Vite is weird about mixing CJS and MJS module formats
  • Update JSX-containing files to .jsx extensions
  • I let the migration script update file imports to use .jsx as well, because ESlint complains about being 'unable to resolve module ____'

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 22, 2025

🚀 Deployed on https://pr-53.climate-app.netlify.dhis2.org

@KaiVandivier KaiVandivier changed the base branch from ci-add-workflows to main January 23, 2025 12:19
@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 15:18 Inactive
@KaiVandivier KaiVandivier changed the title fix(deps): upgrade app platform to v12 fix(deps): upgrade app platform to v12 for Vite and React 18 Jan 23, 2025
@turban turban self-requested a review January 23, 2025 15:23
Copy link
Contributor

@turban turban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment: is it possible to get rid of the "GitHub Actions / lint / lint" warnings?
I've done some manual tests of the app with this branch, and everything seems to work fine!

@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 16:03 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 16:32 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 16:47 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 17:23 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2025 13:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2025 14:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2025 15:32 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2025 16:00 Inactive
@turban turban merged commit a8f0dcf into main Jan 24, 2025
8 checks passed
dhis2-bot added a commit that referenced this pull request Jan 24, 2025
## [1.5.2](v1.5.1...v1.5.2) (2025-01-24)

### Bug Fixes

* **deps:** upgrade app platform to v12 for Vite and React 18 ([#53](#53)) ([a8f0dcf](a8f0dcf))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants