Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated/removed object references (DHIS2-19062) #3325

Merged
merged 6 commits into from
Mar 12, 2025

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jan 27, 2025

Implements DHIS2-19062

Key features

  1. remove deprecated userCredentials object references
  2. remove deprecated userAccesses, userGroupAccesses, externalAccess, publicAccess

Description

The userCredentials object is not returned inside the user object anymore.
The access objects are returned as part of sharing.
See: https://github.com/dhis2/dhis2-releases/blob/master/releases/deprecated-features.md#removed-features

userAccesses, userGroupAccesses, publicAccess, externalAccess
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 27, 2025

🚀 Deployed on https://pr-3325.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify January 27, 2025 10:51 Inactive
@jenniferarnesen
Copy link
Collaborator

jenniferarnesen commented Mar 4, 2025

Confirmed that the following fields have not been returned from the api starting in v41

  • externalAccess
  • publicAccess
  • userAccesses
  • userGroupAccesses

image

image

image

I also am finding that regardless of what user fields are indicated in the request, the same ones are always returned: id, code, name, displayName, username. Also, looking at the above screenshots, it looks like userCredentials hasn't been part of the user object since at least 2.39

@jenniferarnesen jenniferarnesen changed the title chore: remove useCredentials api references chore: remove userCredentials api references Mar 4, 2025
@edoardo edoardo marked this pull request as ready for review March 7, 2025 13:03
@dhis2-bot dhis2-bot temporarily deployed to netlify March 7, 2025 13:05 Inactive
@edoardo edoardo changed the title chore: remove userCredentials api references chore: remove deprecated/removed object references (DHIS2-19062) Mar 7, 2025
@dhis2-bot dhis2-bot temporarily deployed to netlify March 11, 2025 14:15 Inactive
@edoardo edoardo merged commit b62efcf into master Mar 12, 2025
26 checks passed
@edoardo edoardo deleted the chore/remove-userCredentials-references branch March 12, 2025 09:59
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants